[PATCH] Updated add/edit account window

Chris Shoemaker c.shoemaker at cox.net
Thu Jan 19 13:41:24 EST 2006


On Thu, Jan 19, 2006 at 07:21:49PM +0100, Eskil Bylund wrote:
> While we're at GncTreeModelAccountTypes, there are some other changes
> I would like to make.
> 1. Remove gnc_tree_model_account_types_get/set_selection, which
> handles the selection of a GtkTreeView.

They are used by the account page and the budget page.

> 2. Rename gnc_tree_model_account_types_get/set_selected to
> _get/set_visible and change GNC_TREE_MODEL_ACCOUNT_TYPES_COL_SELECTED
> to GNC_TREE_MODEL_ACCOUNT_TYPES_COL_VISIBLE.

Hmmm... I'm not sure I follow...

> 
> This is to change the Filter By dialog to use a checkbox for selection
> of account types, instead of using the selection of the tree view.
> (I.e. make it similar to the Visible columns in Nautilus).
> To see why this is wanted, try and select some visible types in the
> current filter dialog using only your keyboard or mouse. It's
> difficult, not to say impossible.
> 
> I'll have a patch ready soon. It'll probably make more sense then my
> attempt to explain above...
> 
> Anyone got any comments on this?

Only that the static tree model probably shouldn't contain selection
state.  It might be shared by multiple views that want different
selections.

Maybe that's why you wanted to provide the treemodel as an argument?
So you could filter the non-static treemodels?

-chris


More information about the gnucash-devel mailing list