[Gnucash-changes] r12999 - gnucash/trunk/lib/libqof/qof - Re-enable logging for GnuCash modules that haven't explicitly set their

[Neil Williams]

On Saturday 28 January 2006 5:17 pm, Chris Shoemaker wrote:
> Author: chris
> Modified:
>    gnucash/trunk/lib/libqof/qof/qoflog.c
> Log:
>    Re-enable logging for GnuCash modules that haven't explicitly set their
>    own levels.

Chris, the API for this is qof_log_set_global - please don't mess up the 
log_check function because this breaks pilot-qof behaviour!

I would like this patch reverted and a call to qof_log_set_global set in 
gnucash-bin.c (or somewhere else that is gnucash-specific).

Call qof_log_set_level_global to a default level and then set selected modules 
to higher or lower levels.

If modules aren't being logged, it is not up to QOF to overrule the process.

> +static QofLogLevel global_default_loglevel = 0;

Incompatible with pilot-qof and other qof programs which ONLY enable --debug 
when the option is explicitly added to the command line.

QOF does not log anything unless explicitly requested to do so. It must remain 
so.

> -	/* if log_module not found, do not log. */

This is the API.

I cannot accept this patch into QOF in this form.

-- 

Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20060128/3709adfd/attachment.bin