Imbalance split added on quickfill, r13477 (was: Gnucash hangs on quickfill, r13471)

[Chris Shoemaker]

On Sat, Mar 04, 2006 at 10:58:17PM +0100, Christian Stimming wrote:
> Am Samstag, 4. März 2006 19:15 schrieb Chris Shoemaker:
> > Thanks for bisecting this, Andrew.  And thanks for noticing this,
> > Christian.  It was definitely my bug.  Should be fixed in r13476.
> 
> Thanks, Chris, for reacting very quickly. 

<OT> BTW, I jump on regressions ASAP because I've learned that, on a
short time-scale, the cost of fixing a regression is approximately
exponential in the time elapsed since regression.  This is especially
true for the person who caused the regression.  This is in stark
contrast to the cost of fixing long-standing bugs, which is
approximately constant.  Therefore, fixing even a minor regression is
always a higher priority than fixing other bugs, because that's the
most efficient use of time. </OT>

> Indeed the problem is fixed in 
> r13477, and this is no longer a reason for delaying 1.9.2.
> 
> *However*, a new problem occurs when using the quickfill: Suddenly some 
> quickfilled transactions are created as "multi-part transactions", which, 
> when viewed in "Split" mode, turns out to be the original splits *plus* an 
> extra split to the Imbalance-EUR account... that's not quite nice :-) 

Ok, this should be fixed in r13487.  Changing the amount in the
transaction line now changes both split amounts.

> 
> To reproduce: Open account register. Enter a description that will activate a 
> quickfill entry. Click <tab>. Then *modify* the amount. Click <enter>. The 
> resulting transaction will have an extra Imbalance-EUR split with the 
> difference between the original amount and your modified amount.

Thanks for the detailed instructions.  In case you haven't realized,
there are so many different usage patterns for the register that the
chances that my testing covers all your use cases is, unfortunately,
rather small.  I've never adopted the practice of editing the amount
in the transaction line, for example.  I always expand the splits.

-chris