File loading significantly slowed down in r13460
Chris Shoemaker
c.shoemaker at cox.net
Sun Mar 5 18:48:21 EST 2006
On Sun, Mar 05, 2006 at 06:20:20PM -0500, Chris Shoemaker wrote:
> On Sun, Mar 05, 2006 at 02:39:26PM +0100, Christian Stimming wrote:
> > Should I track this down in more detail, like obtaining a function list of
> > cachegrind? Or is it already obvious for you where the problem might be?
>
> Oh, I have a pretty good idea what this is all about. I don't seem to
> have any noticable time difference in my tests, but I knew there would
> be a cost when I wrote it, and I marked it FIXME. From
> xaccSplitCommitEdit():
>
> mark_acc(acc);
> //FIXME: should really be in xaccAccountCommitEdit
> xaccAccountSortSplits (acc, TRUE);
> xaccAccountRecomputeBalance(acc);
>
> This is forcing a resort of the splits after every
> xaccTransCommitEdit. That's really incorrect, but let me just make
> sure that resorts are happening in all the right places before I
> remove that.
Can you please verify that performance is restored in r13498? Thanks.
-chris
More information about the gnucash-devel
mailing list