[Gnucash-changes] r13639 - gnucash/trunk - * lib/libqof/backend/file/qsf-backend.c: add <locale.h>

[Neil Williams]

On Wednesday 15 March 2006 5:08 pm, Derek Atkins wrote:
> Author: warlord
> Date: 2006-03-15 12:08:08 -0500 (Wed, 15 Mar 2006)
> New Revision: 13639
> Trac: http://svn.gnucash.org/trac/changeset/13639
>
> Modified:
>    gnucash/trunk/ChangeLog
>    gnucash/trunk/lib/libqof/backend/file/qsf-backend.c
> Log:
> 	* lib/libqof/backend/file/qsf-backend.c:  add <locale.h>
> 	  Note:  it think it's probably wrong to set the locale here.

It's a GModule - it needs to load the locale itself according to whether the 
backend is loaded from internal gnucash (use the gnucash text domain) or 
libqof1 (use the qof text domain).

> Modified: gnucash/trunk/lib/libqof/backend/file/qsf-backend.c
> ===================================================================
> --- gnucash/trunk/lib/libqof/backend/file/qsf-backend.c	2006-03-15 16:57:29
> UTC (rev 13638) +++
> gnucash/trunk/lib/libqof/backend/file/qsf-backend.c	2006-03-15 17:08:08 UTC
> (rev 13639) @@ -30,6 +30,7 @@
>  #include "qsf-dir.h"
>  #include <errno.h>
>  #include <sys/stat.h>
> +#include <locale.h> /* for setlocale() and LC_ALL */
>
>  #define QSF_TYPE_BINARY "binary"
>  #define QSF_TYPE_GLIST  "glist"
> @@ -1248,6 +1249,9 @@
>  {
>  	QofBackendProvider *prov;
>
> +	/* XXX: Do we REALLY want to do this??? 

Yes.

> Shouldn't the APP 
> +	 * have already done this?
> +	 */

There is no "app", it's a GModule, loaded independently by libqof1. The module 
knows nothing of the app using the library, therefore it cannot locate the 
text domain, so it needs it's own - which it has. libqof1 is translated by 
the GNU TP.
http://www.iro.umontreal.ca/translation/registry.cgi?domain=qof

-- 

Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20060315/543d63f3/attachment.bin