[Gnucash-changes] r13926 - gnucash/trunk - Add an alternate mode for handling the dirty state of instances and

[David Hampton]

On Sun, 2006-05-07 at 22:07 -0400, Chris Shoemaker wrote:

> Why is this after the "on_free" case?

So that deleting the blank transaction will not cause the collection to
be dirtied.

> Deleting an object will result
> in calling qof_commit_edit_part2() with do_free set, so this
> qof_collection_mark_dirty() will never be reached.

> So, if the collection isn't marked dirty on committing a deleted
> object, and if the freeing functions, which call
> qof_instance_release(), which calls qof_entity_release(), which calls
> qof_collection_remove() also no longer dirties the collections, then I
> don't see how the book would be dirtied when an object is deleted.

I tested these changes when deleting an existing transaction and the
book was dirtied.

> Somehow, sometime, deleting an object needs to result in a dirty book,
> even though it contain collections of only clean instances (entities).

If you have a solution for dirtying the book when deleting a
pre-existing object that also doesn't dirty the book when deleting the
blank split or blank transaction, I'd love to hear it.

David