Request for review: patch for bug 499496

[Daniel Harding]

Derek Atkins wrote:
> Hi,
> 
> Daniel Harding <dharding at gmail.com> writes:
> 
>> Hello,
>>
>> I have put together a patch for a bug I filed a few weeks back.  This is 
>> my first attempt to make any real changes to the GnuCash sources, so I'd 
>> appreciate feedback on both my approach to addressing the bug, as well 
>> as the format/style of the changes themselves.  I've attached the patch, 
>> along with a (hopefully clear) description of what it is trying to do, 
>> to the bug report:
>>
>> http://bugzilla.gnome.org/show_bug.cgi?id=499496
> 
> Thanks.  Committed to trunk as r16730.

Realized a small problem with my patch.  Got the logic reversed for an
#if which was intended to disable a warning which currently gets hit all
the time.  Here is a patch that fixes that (alternatively, the whole
chunk of code behind the #if could simply be removed).
Apologies for that,

-Daniel


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: disable_warning.patch
Url: http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20071227/8667810b/attachment.pl