r15582 - gnucash/trunk/packaging/win32

[Andreas Köhler]

Hi,

Christian Stimming wrote:
> the change in the INTLTOOL_PERL env variable made my install.sh fail:
> 
> --- /gnucash/trunk/packaging/win32/install.sh (revision 15575)
> +++ /gnucash/trunk/packaging/win32/install.sh (revision 15582)
> @@ -173,5 +173,5 @@
>      setup ActivePerl \(intltool\)
>      _ACTIVE_PERL_WFSDIR=`win_fs_path $ACTIVE_PERL_DIR`
> -    add_to_env $_ACTIVE_PERL_WFSDIR/bin/perl INTLTOOL_PERL
> +    add_to_env $_ACTIVE_PERL_WFSDIR/ActivePerl/Perl/bin/perl INTLTOOL_PERL
>      if quiet $INTLTOOL_PERL --help
>      then
> 
> ... because if the env variable INTLTOOL_PERL is set to /foo/bar before, the 
> function "add_to_env" will *add* the new setting to the old one instead of 
> overwriting the old one. Calling a "path of two executables" instead of one 
> single executable of course then fails.
> 
> Can you please add some code that clearly *overwrites* these env variables 
> which are not supposed to hold more than one entry? Or should we simply add 
> an INTLTOOL_PERL="" right before this line?

I wanted the script to fail but maybe not this cryptically.  So in 
r15585 set_env_or_die is used instead.  Simply overwriting the 
environment variable would hide the actual problem again.

-- andi5