r16322 - gnucash/branches/register-rewrite/src/gnome-utils - Removed the editing_started_cb function (and related code) that set up the autocompletion and moved the code to

Chris Shoemaker c.shoemaker at cox.net
Wed Jul 18 15:53:49 EDT 2007


On Wed, Jul 18, 2007 at 03:40:25PM -0400, Jeff Green wrote:
> Author: jeff
> Date: 2007-07-18 15:40:23 -0400 (Wed, 18 Jul 2007)
> New Revision: 16322
> Trac: http://svn.gnucash.org/trac/changeset/16322
> 
> Modified:
>    gnucash/branches/register-rewrite/src/gnome-utils/gnc-tree-view-transaction.c
> Log:
> Removed the editing_started_cb function (and related code) that set
> up the autocompletion and moved the code to
> get_editable_start_editing_cb that was already present and set as
> the callback for the "editing-started" signal.  Created the
> model_copy function to copy the data from the Description column of
> the treeview model into a liststore to use as the model for
> autocompletion (to solve the crashes caused by using the treeview
> model for autocompletion).  Added code to gtvt_edited_cb to add the
> data from new transactions to the liststore used for autocompletion.

If the solution with the ListStore turns out to be the long-term
solution, we'll have to avoid leaking it, too.  It would have to be
owned by the transaction view, since the GtkCompletion is transient.
IIRC, that means something like g_object_remove_ref() from the dispose
method.

-chris


More information about the gnucash-devel mailing list