80-column width [WAS: Re: indent]

[Josh Sled]

On Thu, 2007-03-08 at 23:46 -0500, David Hampton wrote:
> -l80	Line width of 80.

This one I find problematic.  I understand the arguments for it, and
have made them myself.  But identifiers and type names are just too long
these days.  An 80-char limit can cause frequent and unnatural
line-breaking; I think 100-char limit is more realistic.

I do think a 80-char limit is a good guideline ... but an unbroken
(e.g.) 95-character line is better than an 80-character line followed by
a 15-character line.

See the attached example of over-zealous wrapping differences of
gnc-plugin-page-register.c.

If we persist, I think we should have a convention for where the '='
goes, and that is at the beginning of the next line (like other
"continuing" operators).


Note that I think -lc80 is very reasonable, though.

-- 
...jsled
http://asynchronous.org/ - a=jsled;b=asynchronous.org; echo ${a}@${b}
-------------- next part --------------
jsled at phoenix [~/stuff/proj/gnucash/src-trunk]$ egrep -n -A1 "= *$" ~/tmp/register-80.c ; egrep -n -B1 "^ *=" ~/tmp/register-80.c 
381:static guint gnc_plugin_page_register_n_actions =
382-G_N_ELEMENTS(gnc_plugin_page_register_actions);
--
535:        gnc_plugin_page_register_type =
536-            g_type_register_static(GNC_TYPE_PLUGIN_PAGE,
--
640:    gnc_plugin_class->update_edit_menu_actions =
641-        gnc_plugin_page_register_update_edit_menu;
--
669:    action_group =
670-        gnc_plugin_page_create_action_group(parent,
--
877:    priv->component_manager_id =
878-        gnc_register_gui_component(GNC_PLUGIN_PAGE_REGISTER_NAME,
--
948:    priv->gsr->window =
949-        GTK_WIDGET(gnc_window_get_gtk_window(GNC_WINDOW(window)));
--
1080:    use_double_line =
1081-        g_key_file_get_boolean(key_file, group_name, KEY_DOUBLE_LINE, &error);
--
1126:        account =
1127-            gnc_account_lookup_by_full_name(gnc_book_get_root_account(book),
--
1844:            name =
1845-                g_strconcat(account_name, " ", _("and subaccounts"), " - ",
--
2457:    window =
2458-        gnc_window_get_gtk_window(GNC_WINDOW(GNC_PLUGIN_PAGE(page)->window));
--
3029:            label =
3030-                gnc_plugin_page_register_get_tab_name(GNC_PLUGIN_PAGE(page));
--
3050:        visible_page =
3051-            gnc_main_window_get_current_page(GNC_MAIN_WINDOW(window));
jsled at phoenix [~/stuff/proj/gnucash/src-trunk]$ egrep -n -A1 "= *$" ~/tmp/register-100.c
781:    priv->component_manager_id =
782-        gnc_register_gui_component(GNC_PLUGIN_PAGE_REGISTER_NAME,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20070309/155c88cb/attachment.bin