r15999 - gnucash/trunk/packaging/win32 - Do not double-check libraries/programs if they are installed correctly.

[Derek Atkins]

Andreas Köhler <andi5.py at gmx.net> writes:

> Hi,
>
> Am Sonntag, den 06.05.2007, 23:26 -0400 schrieb Derek Atkins:
>> I don't think I asked this earlier, but why did you remove
>> this added check?  I found it useful to me when I was working
>> on the install.sh code to make sure I actually installed stuff
>> properly.  It was also useful to me to die earlier when an
>> installation failed for some reason, or if I accidentally
>> installed something in a place where the script didn't expect
>> it.
>
> I did not remove these checks completely, but rather moved them into the
> not-yet-installed blocks.
>
> Before:
> if $do_some_time_consuming_check
>   echo skip
> else
>   $install
> fi
> $do_some_time_consuming_check || die
>
> Now:
> if $do_some_time_consuming_check
>   echo skip
> else
>   $install
>   $do_some_time_consuming_check || die
> fi
>
> So I do not think we fail fewer times now, but install.sh runs are a bit
> faster.
>
>> -derek
>
> -- andi5

Ahh, I guess I missed this from the patch.  Sorry

-derek
-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available