Two small gui improvements

Geert Janssens janssens-geert at
Mon Oct 8 09:40:17 EDT 2007

Hi Andreas,

Thanks for committing my first patch !

As for the second, you are more then correct. I think your solution is way 
more elegant. Please go for that one.

I still have a lot to learn about GUI development with gtk and glade. I like 
it though, so when I find the time, I may dig into the gnome hig you point 
to, and where possible make some more improvements.



On Monday 8 October 2007, Andreas Köhler wrote:
> Hi Geert,
> Am Mittwoch, den 03.10.2007, 23:54 +0200 schrieb Geert Janssens:
> > Based on some issues I encountered today with posting invoices (see also
> > the irc logs for more details), I have done some minor gui improvements
> > in the business dialogs. They don't solve my post problem at the core
> > (that would require more indepth programming knowledge), but they help
> > improve visibility.
> >
> > 1. The post dialog
> > Current situation: the information in the "Post to account" field is not
> > completely visible. Widening the dialog doesn't help, because the field
> > has a fixed with and doesn't expand.
> > New situation: when the dialog expands, the variable fields expand with
> > it. This allows for the "Post to account" to grow until the full account
> > text is visible.
> Applied as r16555, together with a change to the newAccountButton to
> make it non-expanding.
> > 2. Search dialog
> > Current situation: sometimes when the search returns a lot of results, a
> > lot of scrolling is required to get to the desired result. Increasing the
> > size of the search dialog doesn't help, because the result part of the
> > dialog has a fixed height.
> > New situation: I have added a split pane widget (along with some changes
> > to keep the end result tidy). With this, the user can increase the size
> > of the result part independently from the search criteria part.
> > Currently, the search criteria part is about one criterium high. This can
> > still be changed if needed.
> Hm.  From my point of view a viewport inside a scrolledwindow inside an
> expanding&filling frame inside an vpaned is overkill :-D
> What do you think about something along the lines of the attached diff?
> It removes the scrolledwindow and viewport, makes the frame
> non-expanding and puts the "type of search" to the bottom.  If you add
> search criteria the results widget is simply made smaller.
> > I have attached two diff files (generated with svn diff) for the affected
> > glade files.
> >
> > I hope you guys find the modifications useful.
> Thank you a lot for your work!  If you have the time and want to help
> us, the business dialogs need a lot of hig[1] love :-)
> -- andi5
> [1]

More information about the gnucash-devel mailing list