G_LOCK problem (was: gda branch errors)

[David Reiser]

On Apr 6, 2008, at 6:05 PM, David Reiser wrote:

>
> On Apr 6, 2008, at 4:46 PM, Andreas Köhler wrote:
>
>> Hi David,
>>
>> Am Sonntag, den 06.04.2008, 16:11 -0400 schrieb David Reiser:
>>> If I enable error-on-warning, building gda-dev2, svn 17068 fails
>>> with:
>>>
>>> gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -DG_LOG_DOMAIN=
>>> \"gnc.backend.xml\" -I/sw/include -I.. -I../.. -DLOCALE_DIR=\"/opt/
>>> gnucash-gda/share/locale\" -I../../../src/backend -I../../../src/
>>> engine -I../../../src/core-utils -I../../../lib/libc -I/sw/include/
>>> libxml2 -I../../../lib/libqof/qof -I../../../lib/libqof/qof -I/sw/
>>> include/glib-2.0 -I/sw/lib/glib-2.0/include -DORBIT2=1 -I/sw/ 
>>> include/
>>> glib-2.0 -I/sw/lib/glib-2.0/include -I/sw/include/orbit-2.0 -I/sw/
>>> include/gconf/2 -Werror -Wdeclaration-after-statement -Wno-pointer-
>>> sign -D_FORTIFY_SOURCE=2 -g -Wno-unused -MT io-gncxml-v2.lo -MD - 
>>> MP -
>>> MF .deps/io-gncxml-v2.Tpo -c io-gncxml-v2.c  -fno-common -DPIC -
>>> o .libs/io-gncxml-v2.o
>>> cc1: warnings being treated as errors
>>> io-gncxml-v2.c: In function ‘try_gz_open’:
>>> io-gncxml-v2.c:1350: warning: passing argument 1 of
>>> ‘g_atomic_pointer_get’ from incompatible pointer type
>>> io-gncxml-v2.c:1355: warning: passing argument 1 of
>>> ‘g_atomic_pointer_get’ from incompatible pointer type
>>> io-gncxml-v2.c: In function ‘wait_for_gzip’:
>>> io-gncxml-v2.c:1366: warning: passing argument 1 of
>>> ‘g_atomic_pointer_get’ from incompatible pointer type
>>> io-gncxml-v2.c:1374: warning: passing argument 1 of
>>> ‘g_atomic_pointer_get’ from incompatible pointer type
>>> make[5]: *** [io-gncxml-v2.lo] Error 1
>>>
>>> I'm using glib 2.16.2, so something might have changed recently with
>>> respect to G_LOCK
>>
>> Does the attached patch (against trunk) fix this warning for you?
>>
>> Yours,
>> -- andi5
>>
>> <lock.patch>
>
> No. Same error. Both on trunk and gda-dev2, patched or not.
>
> I successfully built trunk r17034 on March 16 (after I first built
> glib 2.16.1, but I'm not sure I had it active at the time of the
> gnucash build).
> I first built glib 2.16.2 on April 2. I'll try rolling back my glib
> version to see what successfully supports a gnucash trunk build.
>
> It is not out of the realm of possibility that Apple's build tools are
> also involved. There have been some interesting interactions with
> pieces of gnome lately in the Mac realm.

I haven't confirmed yet, but it looks like in their zeal to quiet  
warnings on gcc 4.3, they've caused a problem for macs. I think the  
'offending' edit is:
http://svn.gnome.org/viewvc/glib/trunk/glib/gthread.h?r1=5792&r2=6691
which would put it squarely between glib 2.16.1 and 2.16.2 release  
dates.

Dave
--
David Reiser
dbreiser at earthlink.net