Posting time bug fix proposal (simplified)

[Charles Day]

On Fri, Aug 15, 2008 at 7:46 AM, Derek Atkins <warlord at mit.edu> wrote:

> Christian Stimming <stimming at tuhh.de> writes:
>
> > Am Donnerstag, 14. August 2008 22:51 schrieb Charles Day:
> >> On Wed, Aug 6, 2008 at 9:33 AM, Charles Day <cedayiv at gmail.com> wrote:
> >> > Previously I proposed an initial fix for the "posting time" bug
> (#137017)
> >> > that involved no new features and use of a fixed time zone of UTC
> >> > internally. See:
> >> >
> https://lists.gnucash.org/pipermail/gnucash-devel/2008-July/023613.html
> >>
> >> Has everyone forgotten about this patch, or lost interest? After all the
> >> earlier discussion, I am a bit surprised to see no responses here or in
> the
> >> bug report. If this is worse than the status quo, somebody please say
> so.
> >
> > Sorry for that - lost interest, and also I didn't immediately see how
> this
> > actually changes the semantics in comparison to the status quo.
> >
> > After reviewing your explanation and your patch again, this seems to me a
> good
> > solution for the time being.
> >
> > I think it should be fine to commit this into SVN (trunk), because by
> > definition trunk is a development branch.
>
> How does this patch handle the (non-default) time used in the
> book closing transactions?
>

I was not aware of this issue. My patch doesn't change the backend's file
writing code, so whatever timestamp is assigned by GnuCash is what gets
saved. If the time written isn't midnight, the patch will think that the
transaction is bug-affected when the file is read in again.

Could you explain about the time used in book closing transactions? I had
hoped to avoid changing the file writing part of the code, but maybe that's
not possible.


> -derek
>
> --
>        Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>       Member, MIT Student Information Processing Board  (SIPB)
>       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
>       warlord at MIT.EDU                        PGP key available
>

Cheers,
Charles