AUDIT: r16976 - gnucash/trunk - QIF import: Show the druid's documentation pages by default. Previously these pages were hidden by default.

[Charles Day]

On Sat, Mar 8, 2008 at 8:09 AM, Andreas Köhler <andi5.py at gmx.net> wrote:

> Hi Charles,
>
> On So, 2008-03-02 at 14:19 -0800, Charles Day wrote:
> > On Thu, Feb 28, 2008 at 3:45 PM, Charles Day <cedayiv at gmail.com>
> > wrote:
> >         On Thu, Feb 28, 2008 at 3:16 PM, Andreas Köhler
> >         <andi5.py at gmx.net> wrote:
> >                 > QIF import: Show the druid's documentation pages by
> >                 default. Previously these pages were hidden by
> >                 default.
> >                 > BP
> >
> >                 I just wonder, whether it is really necessary to
> >                 backport this one?  Did
> >                 anyone bother before, is there a bug about it?  I know
> >                 that other
> >                 commits were chosen as well, but e.g. white-space
> >                 fixes greatly ease
> >                 later merges.  But, hey :-D
> >
> >         I feel it is a bug, yes, as Ian stated that those helpful
> >         "documentation" pages were not intended to be hidden by
> >         default. This could be filed as a Bugzilla bug, though Derek,
> >         Ian and I happened to work through it on the mailing list
> >         instead.
>
> Ok, you were probably right.  I am sorry for being too harsh.
>

Thanks. Sorry for requesting an additional backport at the very last minute.

> If I delete the "The setting can't be found." comment and replace the
> > three printfs with g_warning, would that satisfy your concerns about
> > backporting this?
>
> Yes, please do that :-)
>

OK, committed as r17018. Hopefully the additional change to use #defines is
OK with you. I noticed that the gconf section already had a #define so I
used it and added one for "show_doc".

Cheers,
Charles


> > Would you also like me to file a bug for the failure to show
> > documentation pages by default?
>
> No, not necessarily.
>
> > I have filed bug 519988 for the QIF importer's overall error reporting
> > problems.
>
> Thanks!
>
> -- andi5
>
>
>