[PATCH] AqBanking version checks

Christian Stimming stimming at tuhh.de
Wed Mar 19 17:11:54 EDT 2008


Am Montag, 17. März 2008 23:47 schrieb Andreas Köhler:
> Hi Christian,
>
> I wonder whether the attached patch is correct and can be applied.

Yes, and yes.

> Additionally, do you think it is sensible that I as (aq) newbie try to
> invest some time on the AqBanking 3 port?  I suppose that, unless the
> patch becomes too large or even excludes AqBanking 2, the results of
> that port, if someone actually finishes it, are to be backported to
> branches/2.2?  I would mark this one BP then to lessen cluttering and
> ease merges.

BP is good here as well. As for aqbanking3 porting: Sure, go ahead. You have 
probably noticed some #define's in gnc-hbci-utils.h - those were the easy 
ones and can always be added in the existing codebase. However, eventually I 
think an aqbanking3-enabled gnucash cannot at the same time be compiled with 
aqbanking2 anymore, even with tons of #ifdef's. This may or may not prevent 
us from BP - I don't know so far.

> PS: Cmake will probably have to wait until I have nothing better to do
> again ;-)

Heh. BTW on windows CMake already includes a "make package" rule that not only 
wraps up a zip but additionally compiles an NSIS setup.exe directly from the 
CMakeLists.txt settings... Whatever. I'm on holiday the next weekends and 
drowning in work during the week, hence I will probably be slow on answering 
emails.

Regards,

Christian


More information about the gnucash-devel mailing list