[PATCH] quote fetching ability in transfer dialog

Christian Stimming stimming at tuhh.de
Tue Nov 25 05:59:33 EST 2008

Hi Jamie,

thanks for the patch. However, did you notice the patch will change the full 
file, not only the parts that are touched by your changes? After I saw this, 
I opened the glade file with my locally available "glade-2" editor 
(glade-2 --version gives "2.12.1"), which changed the indentation back to the 
original style. But opening the glade file with my local version also gave 
the following warning:

** (glade-2:24651): WARNING **: Invalid radio group: price_radio
   (Note that forward references are not allowed in Glade files)

For that reason I'm not sure whether my older glade hasn't accidentally 
removed some of your GUI parts. Additionally, I'm also not sure whether your 
original patched glade file is indeed compatible with my (and thus, many old) 
libglade version at run-time. I've attached the patch that comes out when I 
apply your patch and open and save the glade file with my local glade-2 
version again. Could you please verify whether this still contains all of 
your GUI elements? If yes, I'd commit.

Thanks a lot!


Am Donnerstag, 20. November 2008 22:45 schrieb jamie campbell:
> (oops, originally did 'reply' instead of 'reply all')
> Done, I also searched for urgency_hint and this time it doesn't seem to
> have added it, so it shouldn't need to be filtered out..
> -Jamie
> Christian Stimming wrote:
> > Am Dienstag, 11. November 2008 22:10 schrieb jamie campbell:
> >> This patch adds a button to get the latest rate.
> >
> > The patch itself was fine. But I'd like to ask you to spend a little
> > extra work here with respect to the placement of the "Fetch Rate" button.
> > Right now it's the rightmost button, but IIRC according to the Gnome HIG
> > and all the rest of gnucash the rightmost button should be the "Ok"
> > button. Can you move the "Fetch Rate" button somewhere else? Either to
> > the left, or even rather in the same line as the textbox of the exchange
> > rate. Thanks!
> >
> > Christian
> >
> >> It's part of the Gnucash multicurrency extensions project I'm working
> >> through, see also emails Nov 4th 16:42; Nov 4 16:46; Oct 31 16:14 , as
> >> well as the original proposal email oct 23 16:34  (It seems like we're
> >> mostly a 16:00 kind of group)
> >>
> >> -Jamie
> >> _______________________________________________
> >> gnucash-devel mailing list
> >> gnucash-devel at gnucash.org
> >> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fetchButtonMoved-CS.patch
Type: text/x-diff
Size: 47289 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20081125/32fbd55f/attachment-0001.bin 

More information about the gnucash-devel mailing list