[PATCH] Budget Reports fixes
Andreas Köhler
andi5.py at gmx.net
Sun Jan 18 12:27:57 EST 2009
Hi Forest,
all three patches are online as r17829. Thanks a lot!
As usual, I cannot really help with report changes, I simply checked the
obvious things and hope that Josh and all the others will contribute
better feedback now.
Regarding white space in .scm files, I have got the feeling that it is a
mess. Personally, I would prefer space-only, emacs style indented
files, but committing massive whitespace changes makes backports a lot
harder. One thing I observed though is that opening parentheses on
single lines after lets look strange to me :-)
Ciao,
-- andi5
Forest Bond wrote:
> Hi Andreas,
>
> Attached are two patches correcting issues with my recently submitted
> budget-related reports. As requested, these patches apply on top of my
> previously-sent patch.
>
> As always, your feedback is appreciated.
>
> The whitespace conventions for .scm files are not entirely clear to me. The
> whitespace in my scheme code is quirky. It appears that this is not entirely
> unusual in the existing report code, but I may follow up with a patch to correct
> this, unless such patches are generally not preferred.
>
> Thanks for your time.
>
> Thanks,
> Forest
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: OpenPGP digital signature
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20090118/8644c159/attachment.bin
More information about the gnucash-devel
mailing list