AUDIT: r17840 - gnucash/trunk/src/register/ledger-core - Register: Add additional debugging output during register cleanup. Also rename a variable for clarity and to match typical usage in the rest of the ledger code.

[Derek Atkins]

Hi,

Charles Day <cedayiv at gmail.com> writes:

> On Thu, Jan 22, 2009 at 11:02 AM, Derek Atkins <warlord at mit.edu> wrote:
>
>     Charles Day <cedayiv at cvs.gnucash.org> writes:
>    
>     > Register: Add additional debugging output during register cleanup. Also
>     rename a variable for clarity and to match typical usage in the rest of
>     the ledger code.
>     > BP
>    
>     Why is this something that should be back ported?
>
> Do you not want new debugging output backported? I had to add this to
> troubleshoot the register with a user (bug 426111), as he could randomly
> reproduce the problem himself but could not describe how to make it happen for
> others. It would be nice to have this change released so that users can
> produce this output on request with --log gnc.ledger=debug if/when we can't
> reproduce their problem.

I think it depends where we are in the lifecycle of the stable
release.  Right now I'd consider 2.2 "nearing its end", and really we
should limit changes to true bug fixes, and even then we should be
conservative about what it is that we're fixing.  Simultaneously I
think we should seriously think about the 2.3/2.4 lifecycle.

> As for the variable name change, that's strictly optional, but the old name
> was confusing when read in context with all the other functions in that file.
>
> Incidentally, I just committed a bunch of changes related to doxygen. I guess
> those don't really have to be backported if documentation is never produced
> from branches, though it seems innocuous.

Innocuously-seeming changes often come back to bite us.  Just look
at the one-line change put into 2.2.8 that causes "close invoice"
to crash!

I would recommend caution and restraint about backporting changes.
If it's not a crasher, if it's not causing data loss or data corruption,
then it probably doesn't need to get backported.

In terms of adding debugging output....  That's definitely a tough
call.  If the problem is so subtle that we can't figure it out then
it's probably minor enough that I would err on the side of "wait for
2.3".

And yes, documentation is built off trunk, not 2.2.

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available