[PATCH] - bug #554394 - Income Tax Enhancements - missing German patches attached

[J. Alex Aycinena]

Hello,

On Mon, Nov 2, 2009 at 12:13 PM, J. Alex Aycinena
<alex.aycinena at gmail.com> wrote:
> Hello,
>
> I realised after sending this in last night that the changes included
> in the patchfile would break the functioning of the existing,
> otherwise unmodified, German version of the tax report.

snip

>
> Christian,
>
> Since I believe you are the author of the German version of the tax
> report, I would appreciate it if you especially would look over these
> changes. I have to set up a German locale to test them, which I have
> not yet done but will do next.

I set up a German locale in a VM and compiled r18406 from svn, with
none of my patches applied. When I looked at the Edit->Tax Options
dialog, I expected to see German tax codes displayed as selection
possibilities but instead they were US codes. When I ran the Tax
Report, the US version was displayed, not the German version.

I checked to see that LC_ALL = "de_DE", both on the command line and
by inserting code and checking with gdb; it was.

It seems that the location selection code in either 'gncmod-tax-us.c'
or in 'gncmod-locale-reports-us.c' is not being called; when I put
breakpoints in both and ran gnucash neither seemed to run since the
application didn't stop anywhere.

So I installed gnucash 2.2.9 and ran it in the German VM. Again, when
I looked at the Edit->Tax Options dialog, I saw US codes rather than
German tax codes displayed as selection possibilities.  When I ran the
tax report, while it was in German, it was the US version with
translated strings, rather than the German version (I checked by
modifying the report).

Is this the way it's supposed to work? Does this mean the German
income tax features are kaput and the German patches I sent are not
needed?

Alex