Or maybe not? German tax report should be disabled altogether (Re: [PATCH] - bug #554394 - Income Tax Enhancements - missing German patches attached)

[J. Alex Aycinena]

Dear Christian,

An update:

>On Thu, Nov 5, 2009 at 1:03 AM, Christian Stimming <stimming at tuhh.de> wrote:

snip

>>
>> Did you compile with --enable-locale-specific-tax? Otherwise the selection
>> code of course is not being run.
>>
>
> Ah, that explains it. I didn't know about that. Now that I've started,
> I'll recompile with the switch just to see it work in the unmodified
> system and then again to check how my patches work. Just for the fun
> of it. I'll let you know what I get.
>

I compiled r18406 with '--enable-locale-specific-tax' (and none of my
patches, initially) and it did display the German tax codes in
Edit->Tax Options and generate the German version of the tax report as
it was supposed to.

I then applied my non-German patches and, although the German version
of the tax report would generate, the Edit->Tax Options crashed
because it was looking for scm functions that weren't there. When I
then applied the German patches, it also failed initially - I had to
make some further changes to txf-de_DE.scm. With these changes though,
it works.

>> I don't know whether the German tax features are now "more broken" than
>> before. But to my knowledge it didn't really work at any time, but it rather
>> was a pure proof-of-concept. I'll ask on the German list whether anyone was
>> actually using it, and I'll let you know the result. But most probably I'll
>> remove it.

If you want to remove it, of course go ahead and do so. But the
easiest thing (i.e., least amount of work for you) might be to just go
ahead and apply my patches - the German version of taxes will work no
better, but no worse, than before.

I attach the revised patch for 'txf-de_DE.scm'; primarily I had to change:

(define txf-tax-entity-types
 (list
  (cons '01 #("Individual, Joint, etc." "Files Individual German Tax Return"))
  (cons '99 #("None" "No Income Tax Options Provided"))))

to:

(define txf-tax-entity-types
  (list
   (cons 'Ind #("Individual, Joint, etc." "Files Individual German Tax Return"))
   (cons 'Other #("None" "No Income Tax Options Provided"))))

because the numbers weren't being treated as symbols and
dialog-tax-info.c didn't work right. If you want to change the text
strings to German in these two lines before applying the patch, please
do so.

>> Regards,
>>
>> Christian
>>

Regards,

Alex
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patchtxf-de_DE
Type: application/octet-stream
Size: 6667 bytes
Desc: not available
URL: <http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20091105/6ef8be91/attachment.obj>