Timing for 2.3.8

[Phil Longstaff]

On November 22, 2009 03:28:16 pm Christian Stimming wrote:
> Am Sonntag, 22. November 2009 schrieb Phil Longstaff:
> > There are a number of important fixes in 2.3.8 so I would like to release
> >  it soon.  Are there any new patches or modifications that anyone else
> >  needs to get in (currency trading accounts?  other?)?
> 
> I don't have anything left in the queue, so for me, releasing ASAP is fine.
> 
> However, as you already said, the recently applied currency trading patch
> doesn't yet work correctly because of the scheme error. In the current
>  state I think the corresponding option may get saved correctly but doesn't
>  get looked up correctly, so the feature is probably still simply disabled
>  and you could release it in this state, if necessary. It would be even
>  better if Mike Alexander had some time, as he can probably provide a fix
>  for the scheme crash rather easily, but I guess he is currently away from
>  keyboard and might need some more time until he can provide a patch.

"make check" is failing, and I think it's because of the currency trading 
patch.

phil at phil-laptop:~/gnucash2/trunk/src/engine/test$ gdb .libs/test-lots                             
GNU gdb (GDB) 7.0-ubuntu                                                                           
Copyright (C) 2009 Free Software Foundation, Inc.                                                  
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>                      
This is free software: you are free to change and redistribute it.                                 
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"                         
and "show warranty" for details.                                                                   
This GDB was configured as "i486-linux-gnu".                                                       
For bug reporting instructions, please see:                                                        
<http://www.gnu.org/software/gdb/bugs/>...                                                         
Reading symbols from /home/phil/gnucash2/trunk/src/engine/test/.libs/test-
lots...done.             
(gdb) run                                                                                          
Starting program: /home/phil/gnucash2/trunk/src/engine/test/.libs/test-lots                        
[Thread debugging using libthread_db enabled]                                                      
 Lots: 2 of 60 paired tests . . .                                                                  
Program received signal SIGSEGV, Segmentation fault.                                               
0x003c1b1b in scm_igc () from /usr/lib/libguile.so.12                                              
(gdb) bt                                                                                           
#0  0x003c1b1b in scm_igc () from /usr/lib/libguile.so.12                                          
#1  0x003c1e68 in ?? () from /usr/lib/libguile.so.12                                               
#2  0x003c1fb7 in scm_must_malloc () from /usr/lib/libguile.so.12
#3  0x003f753a in scm_allocate_string () from /usr/lib/libguile.so.12
#4  0x003f7a6f in scm_mem2string () from /usr/lib/libguile.so.12
#5  0x003f7d37 in scm_makfrom0str () from /usr/lib/libguile.so.12
#6  0x003fa91d in scm_c_eval_string () from /usr/lib/libguile.so.12
#7  0x00ea800f in get_scm_string (str_name=0xeba786 "(car gnc:*kvp-option-
path*)") at qofbook.c:445
#8  0x00ea80a5 in qof_book_use_trading_accounts (book=0x805f848) at 
qofbook.c:464
#9  0x001472a3 in xaccTransUseTradingAccounts (trans=0x8086498) at 
Transaction.c:661
#10 0x001478f9 in xaccTransIsBalanced (trans=0x8086498) at Transaction.c:771
#11 0x0013c1c7 in xaccTransScrubImbalance (trans=0x8086498, root=0x0, 
account=0x0) at Scrub.c:582
#12 0x00148836 in xaccTransCommitEdit (trans=0x8086498) at Transaction.c:1140
#13 0x0804fee0 in get_random_transaction_with_currency (book=0x805f848, 
currency=0x8073ab8,
    account_list=0x8083f40) at test-engine-stuff.c:1454
#14 0x08050cc3 in add_random_transactions_to_book (book=0x805f848, 
num_transactions=719)
    at test-engine-stuff.c:1907
#15 0x0804cc6e in run_test () at test-lots.c:56
#16 0x0804cd38 in main (argc=1, argv=0xbffff394) at test-lots.c:91
(gdb) 

Phil