Webkit dependencies

[Derek Atkins]

Phil Longstaff <plongstaff at rogers.com> writes:

> On October 12, 2009 03:46:11 pm Christian Stimming wrote:
>> Am Montag, 12. Oktober 2009 17:34 schrieb Phil Longstaff:
>> > > Are you saying that webkit not only depends on those libraries, but
>> > > also EXPORTS those libraries as part of its interface?  That seems...
>> > > poor. How have you hacked around it?  I think it's fine to #include
>> > > those include files when building webkit, but I would see if there's
>> > > some way to not #include those windows header files when building
>> > > GnuCash.
>> >
>> > The windows .h file only defines GUID if symbol GUID_DEFINED is not
>> > defined, so I put #define GUID_DEFINED before I include webkit.h.  The
>> > windows .h file also needs LPGUID defined, so I added "typedef void*
>> > LPGUID".
>>
>> Same as Derek: I'd be very surprised if the webkit headers will include the
>> libsoup headers and include the windows.h header so that our application
>> code also pulls in the windows.h header. Is there really such an
>> unavoidable header inclusion? That's very weird of webkit and I'd rather
>> expect them to fix this.
>
> webkit.h includes soup headers.  soup-portability.h includes winsock2.h which 
> pulls in other windows headers.  Given that we don't need soup for our use of 
> webkit, I wish they had left it opaque so that we could include soup if we 
> needed it.

This sounds like a bug in webkit-win32.  We should talk to them about
it.  To me, it sounds like soup should be in webket-int.h, not in
webkit.h -- it shouldn't be exposed as part of the webkit API.

> Phil

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available