r19077 - gnucash/trunk - Bug #616696 - Development version warning string should not include hardcode version.

[Christian Stimming]

Dear Geert,

unfortunately even this updated patch won't work.

The problem is that the translators will see the string including @-VERSION-@ 
in the gnucash.pot file, and provide a translation for that. But at runtime, 
the string will be different (due to the creation rule for 
tip_of_the_day.list), as it will contain "2.2.9" instead of "@-VERSION-@" at 
this place. Hence, no translation for this can be found anymore, because the 
translations match only for the string containing @-VERSION- at .

The deeper reason for this is that the version number replacement of any 
placeholder must be done *after translation*, which implies it can only be 
done at run-time and not at install time (which your patch would do).

I think the only solution is to change the code that displays the tip_of_day 
to check whether the string contains "%s", *after translation*. If it does, 
the translated string is passed through g_strdup_printf to insert some version 
number here.

Regards,

Christian


Am Dienstag, 27. April 2010 schrieb Geert Janssens:
> Author: gjanssens
> Date: 2010-04-27 15:41:07 -0400 (Tue, 27 Apr 2010)
> New Revision: 19077
> Trac: http://svn.gnucash.org/trac/changeset/19077
> 
> Modified:
>    gnucash/trunk/configure.in
>    gnucash/trunk/doc/Makefile.am
>    gnucash/trunk/doc/tip_of_the_day.list.in
> Log:
> Bug #616696 - Development version warning string should not include
>  hardcode version. * Improve on the previous fix: really display stable
>  version in tooltip, not current version. * Also revert change of "What's
>  new in GnuCash 2.0" because that's the title actually found in the help
>  manual.
> 
> _______________________________________________
> gnucash-patches mailing list
> gnucash-patches at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches
>