Build problems after r19920

[Derek Atkins]

Hi,

On Sat, December 11, 2010 10:15 pm, Mike Alexander wrote:
> SVN version r19920 introduced a couple of build problems.  This changed
> made src/core-utils/gnc-main.c include "gnome-utils/gnc-version.h".
> This works only if the build directory is the source directory.  I
> normally build in a separate build directory parallel to the source
> directory.  That way I can have both a debug and optimized build and I
> can start over from scratch by just blowing away the build directory
> (or moving it aside).
>
> This problem can be fixed by changing the include to just
> "gnc-version.h" and adding -I${top_builddir}/src/gnome-utils to
> AM_CPPFLAGS in core-utils/Makefile.am, but then you hit another problem
> that I'm not sure how to fix.  The problem is that gnc-version.h is
> built by gnome-utils/Makefile.am, but core-utils is built before
> gnome-utils.  This means that if you build from scratch gnc-main.c
> tries to include it before it exists.
>
> Something needs to get rearranged.  You can't really move
> gnc_get_svn_version to gnome-utils since it needs to be available in a
> non-GUI build.  I don't know what would happen if you tried to build
> gnome-utils before core-utils, but I suspect it wouldn't work.

There is nothing magic about the location of gnc-version.h.  It would be
perfectly reasonable IMHO to move the logic of building that file from
gnome-utils into core-utils.

>            Mike

-derek