r18612 - gnucash/trunk/src - Corrections to r18610 to permit compiling against older versions of glib
jralls at ceridwen.us
Wed Feb 10 21:06:00 EST 2010
On Feb 10, 2010, at 7:17 AM, Derek Atkins wrote:
> John Ralls <jralls at ceridwen.us> writes:
>>> Okay, so key is now NULL, which is fine. But then the second line
>>> just assigns pkey to the VALUE of key, which means pkey == NULL.
>> Got it. That's my GCE.
Gross Conceptual Error.
>>> Fair enough. I wonder if we actually NEED the explicit cast?
>>> If we do then we need to come up with another way of doing it,
>>> maybe by re-assigning after the fill-in call.
>> Yes, otherwise gcc will whine about passing an incompatible pointer.
>> Googling 'gpointer strict-aliasing' produced http://www.hulver.com/scoop/story/2004/4/25/13713/0715,
>> which recommends reassigning, just as you say. I'll add that (along with a stern comment) shortly.
> The new patch looks better.
More information about the gnucash-devel