Patch for colored tabs segfault in trunk

[Tom Van Braeckel]

You're right (g_strrstr to be exact).
I'll keep the guideline in mind about using glib's functions where possible.

Attached is another patch that improves upon the previous one.

Thanks,

Tom Van Braeckel
GSM: 0032 (0) 486 63 58 04


2010/2/15 Christian Stimming <stimming at tuhh.de>

> Am Montag, 15. Februar 2010 schrieb Tom Van Braeckel:
> > Hi guys,
> >
> > Commit 18637 (for *Bug
> > 608329*<https://bugzilla.gnome.org/show_bug.cgi?id=608329>- Patch
> > to add Color to Account tabs) caused a segfault at startup because I had
> > renamed my "Accounts" tab.
> >
> > The attached patch fixes it. There might be a better way but I think this
> > issue should be resolved rather sooner than later...
>
> Applied. Thanks a lot! Unfortunately this patch didn't make it into 2.3.9,
> but
> whatever...
>
> By the way, I guess the correct fix would be to use glib's g_strstr()
> function
> instead of the normal libc's strstr().
>
> Regards,
>
> Christian
>
> >
> > I've updated the AUTHOR's file as well, which might conflict with my
> patch
> > for *Bug 608032 <https://bugzilla.gnome.org/show_bug.cgi?id=608032>.*
> >
> > Best regards,
> >
> > Tom Van Braeckel
> > GSM: 0032 (0) 486 63 58 04
> >
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_colortabs_segfault_better.patch
Type: text/x-diff
Size: 549 bytes
Desc: not available
URL: <http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20100216/60ca51a3/attachment-0001.bin>