r18707 - gnucash/trunk/src/gnome-utils - Change file loading message to "Loading user data..."

Christian Stimming stimming at tuhh.de
Tue Feb 23 15:36:30 EST 2010

Am Montag, 22. Februar 2010 schrieb Geert Janssens:
> Author: gjanssens
> Date: 2010-02-22 10:47:33 -0500 (Mon, 22 Feb 2010)
> New Revision: 18707
> Trac: http://svn.gnucash.org/trac/changeset/18707
> Modified:
>    gnucash/trunk/src/gnome-utils/gnc-file.c
> Log:
> Change file loading message to "Loading user data..."
> Reading file is technically only correct for files not for databases.

This patch changed plenty of of lines within that file. Was there a specific 
reason to do this in the same commit as the actual change? It's not so nice to 
read through lines and lines of whitespace changes, or comment spelling fixes, 
to finally find the actual changed code lines.

I would have strongly preferred to have one commit for the actual message 
change, and another one for all the other cosmetic changes. Git-gui makes this 
extremely easy by its "Stage context" function; I don't know whether other VC 
systems are helpful for this sort of operation, though.

At least, I would kindly ask that your commit message should mention something 
like "Additionally, some spelling fixes in comments and plenty of whitespace 

Just to clarify again: I'm not at all against cosmetic changes or whitespace 
cleanup - they are very helpful and we can have plenty of those. But I would 
like to have them in clearly marked commits, very separate from the actual 
functional changes.




More information about the gnucash-devel mailing list