r18582 - gnucash/trunk/src - Add disambiguation prefix to the word Split where it is the action of a Stock Split.

[Phil Longstaff]

Rather than "Action Column" as the prefix, should it be "Stock Split" or something related to meaning rather than location in the UI?

 Phil
---------
I used to be a hypochondriac AND a kleptomaniac. So I took something for it.




________________________________
From: Christian Stimming <stimming at tuhh.de>
To: Derek Atkins <warlord at MIT.EDU>
Cc: gnucash-devel at gnucash.org
Sent: Tue, January 26, 2010 11:38:12 AM
Subject: Re: r18582 - gnucash/trunk/src - Add disambiguation prefix to the word Split where it is the action of a Stock Split.

Hi Derek,

sorry, I didn't get the question correctly and didn't explain this fully enough: The string "Split" is used much more often that this two times (which I saw immediately in the gnucash.pot file). It is used some 10-15 times. However, all usages except the two here are correctly translated using the "Split Transaction" meaning. Only these two here have a different meaning, and incidentally the meaning in both places is identical again. That's why I used the identical disambiguation prefix.

Regards,

Christian

Zitat von Derek Atkins <warlord at MIT.EDU>:

> Christian Stimming <stimming at tuhh.de> writes:
> 
>> Zitat von Derek Atkins <warlord at MIT.EDU>:
>>>> -  xaccSplitSetAction (split, _("Split"));
>>>> +  /* Translators: This string has a disambiguation prefix */
>>>> +  xaccSplitSetAction (split, Q_("Action Column|Split"));
>>>> 
>>>>    amount = gnc_amount_edit_get_amount (GNC_AMOUNT_EDIT (info->price_edit));
>>>>    if (gnc_numeric_positive_p (amount))
>>> [snip]
>>>> -      gnc_combo_cell_add_menu_item (cell, _("Split"));
>>>> +      /* Translators: This string has a disambiguation prefix */
>>>> +      gnc_combo_cell_add_menu_item (cell, Q_("Action Column|Split"));
>>>>        break;
>>> 
>>> Looks like you used the same disamiguation prefix in both locations.
>>> Shouldn't these be different?  I would expect you'd make the first one
>>> be "Stock Split|Split"?
>> 
>> This was intentional. In both cases it is the text that is displayed
>> in the "Action" column in the register. The former writes the text in
>> the action field of respective split, the latter adds it to the
>> proposals that appear when opening the combo box to edit this field in
>> the register.
> 
> Maybe I don't understand how Q_() works.  How will it let the translator
> provide different translations to the two strings when they are 100% the
> same string?  I thought the point was the provide a unique disamiguation
> string to differentiate the two uses of the same word?
> 
>> So yes, the two places are different use cases of the wording, but
>> eventually both strings end up in the same field in the register, so I
>> figured they should have an identical msgid for translation.
> 
> Yes, they both go into the Action column, but aren't they being used for
> different things?
> 
>> Regards,
>> 
>> Christian
> 
> -derek
> 
> --
>        Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>        Member, MIT Student Information Processing Board  (SIPB)
>        URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
>        warlord at MIT.EDU                        PGP key available
> 



_______________________________________________
gnucash-devel mailing list
gnucash-devel at gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel