RFC: [PATCH] Move the business object implementations from separate module into the main gnucash engine.

Geert Janssens janssens-geert at telenet.be
Sat Jul 3 09:08:51 EDT 2010


On Wednesday 30 June 2010, Christian Stimming wrote:
> The subject says it all: Attached is a patch that moves all business object
> implementations from separate module into the main gnucash engine. Only the
>  C and SWIG files are changed, but the Scheme modules are still left in
>  place (i.e. there is still an almost-empty libgncmod-business-core). Also,
>  I've moved only the actual objects so far, but not yet their serialization
>  implementation for {file,sql,xml}. This shouldn't change any function of
>  anything; it just moves the place of their definitions.
> 
> The nice fact is that this is rather easy.
> 
> I would kindly ask some other developers to apply this locally and see
>  whether this might cause any issues; otherwise IMHO it could be committed
>  any instant.
> 
> Regards,
> 
> Christian
> 
Thanks for this patch. I tried it, but it ends in a compiler error.

It turns out you delete gncBusinessP.h instead of moving it. I guess this is a 
simple omission during patch generation. When I readd this file to the engine 
directory, all works fine.

So with that small correction, the patch can be committed as far as I'm 
concerned.

Geert


More information about the gnucash-devel mailing list