[PATCH] python bindings stability by going without guile

Mark Jenkins mark at parit.ca
Wed Jun 30 17:26:43 EDT 2010


> I´d like to know if I did things halfway correctly :
> I tried
> patch -i python_bindings_stability_without_guile.patch
> 
> in the gnucash directory of Rev 19255.
> 
> It did not find the file "src/optional/python-bindings/gnucash_core.i". When
> I told it  to use "./src/optional/python-bindings/gnucash_core.i" it did
> though.
> 
> I couldn´t make it to accept Makefile.am in the same way. I applied the
> changes by vim then.

I'm able to apply python_bindings_stability_without_guile.patch
(attached) from inside the gnucash source directory without problems
like so:
$ patch -p0 < ../python_bindings_stability_without_guile.patch

But as Geert points out, if you update to at least r19293 you won't have
to apply a patch at all.

> In the directory of the python-bindings I did
> 
> make clean
> make
> sudo make install
> 
> It seemed to work. It´s surely not completely the right way, is it ?

I don't know if make install is supported from sub directories of the
source tree, but you can look to see if up to date installed files
really do get to the destination.

> I didn´t understand Rev 533 in the patchfile for I only know of Rev 19255.

I don't have commit access so I maintain my own svn repository (which
was at one point at 533 in its own numbering) that I keep in sync with
upstream. (so I can be said to be maintaining a patch set, not forking)

This allows me to layer one submission on top of another without having
to wait for acceptance upstream. And it allows me to easily re-submit to
upstream (or others to peek) if upstream changes and previous
submissions can no longer be applied.

My python-bindings trunk repository is here:
http://svn.parit.ca/gnucash/branches/python-bindings/

But thanks to Geert it no longer has anything that upstream trunk
doesn't have -- for now all my patches have been accepted here. Probably
won't be working on (and submitting) any others until 2.4 comes out
unless there are more bug reports.

Interesting in hearing if your stack overflow problems are definitely
gone. I also had some stack overflow problems that I used to compensate
for by doing my "from gnucash import" inside of functions instead of top
of file. No longer need to do that myself.


Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: python_bindings_stability_without_guile.patch
Type: text/x-diff
Size: 2624 bytes
Desc: not available
URL: <http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20100630/57312d52/attachment.bin>


More information about the gnucash-devel mailing list