compile error r18884

[Derek Atkins]

Herbert,

Herbert Thoma <herbert.thoma at iis.fraunhofer.de> writes:

> Hi!
>
> With latest trunk I get a complie error:
>
> cc1: warnings being treated as errors
> gnc-main-window.c: In function ‘main_window_update_page_name’:
> gnc-main-window.c:1928: error: implicit declaration of function ‘g_strstr’
> gnc-main-window.c:1928: error: comparison between pointer and integer
> make[5]: *** [gnc-main-window.lo] Fehler 1
> make[5]: Leaving directory `/home/tma/gnucash/gnucash_cvs/gnucash_work/src/gnome-utils'
> make[4]: *** [all-recursive] Fehler 1
> make[4]: Leaving directory `/home/tma/gnucash/gnucash_cvs/gnucash_work/src/gnome-utils'
>
> It seems that my glib does not have g_strstr but only g_strstr_len

In what version of glib was g_strstr() added/removed?
In what version of glib was g_strstr_len() added/removed?

We need to make sure we support 2.10+

> The following trivial patch seems to fix my problem:
>
> Index: src/gnome-utils/gnc-main-window.c
> ===================================================================
> --- src/gnome-utils/gnc-main-window.c   (Revision 18884)
> +++ src/gnome-utils/gnc-main-window.c   (Arbeitskopie)
> @@ -1924,7 +1924,7 @@
>      /* Update Tooltip on notebook Tab */
>      main_window_find_tab_event(window, page, &event_box);
>
> -    if (g_strstr(old_page_long_name,old_page_name) != NULL)
> +    if (g_strstr_len(old_page_long_name,-1,old_page_name) != NULL)

This might just shift the problem...

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available