Win build: r19739: dbi_conn_error_flag is deprecated

[John Ralls]

On Nov 1, 2010, at 1:38 AM, Christian Stimming wrote:

> Dear John,
> 
> thanks a lot for working on the database lock bug! You are finishing our final issue that was blocking the release. Good work.
> 
> Unfortunately, your recent code errors out on the windows build (which has dbi-0.8.3):
> 
> make[5]: Entering directory `/c/soft/gnucash/build/src/backend/dbi'
> /bin/sh ../../../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../../repos/src/backend/dbi -I../../.. -DG_LOG_DOMAIN=\"gnc.backend.dbi\"  -I/c/soft/autotools/include -I/c/soft/regex/include -I/c/soft/gnome/include -I/c/soft/guile/include -I/c/soft/libdbi/include -I/c/soft/gwenhywfar/include -I/c/soft/hh/include -D_WIN32 -I.. -I../.. -DLOCALE_DIR=\""c:/soft/gnucash/inst/share/locale"\" -I../../../../repos/src/backend -I../../../../repos/src/backend/sql -I../../../../repos/src/debug -I../../../../repos/src/engine -I../../../../repos/src/core-utils -I../../../../repos/lib/libc -I../../../../repos/src/libqof/qof -mms-bitfields -Ic:/soft/gnome/include/glib-2.0 -Ic:/soft/gnome/lib/glib-2.0/include   -DORBIT2=1 -mms-bitfields -Ic:/soft/gnome/include/gconf/2 -Ic:/soft/gnome/include/orbit-2.0 -Ic:/soft/gnome/include/glib-2.0 -Ic:/soft/gnome/lib/glib-2.0/include    -Werror -Wdeclaration-after-statement -g  -mms-bitfields -g  -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations  -Wno-unused -MT gnc-backend-dbi.lo -MD -MP -MF .deps/gnc-backend-dbi.Tpo -c -o gnc-backend-dbi.lo ../../../../repos/src/backend/dbi/gnc-backend-dbi.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../../repos/src/backend/dbi -I../../.. -DG_LOG_DOMAIN=\"gnc.backend.dbi\" -I/c/soft/autotools/include -I/c/soft/regex/include -I/c/soft/gnome/include -I/c/soft/guile/include -I/c/soft/libdbi/include -I/c/soft/gwenhywfar/include -I/c/soft/hh/include -D_WIN32 -I.. -I../.. -DLOCALE_DIR=\"c:/soft/gnucash/inst/share/locale\" -I../../../../repos/src/backend -I../../../../repos/src/backend/sql -I../../../../repos/src/debug -I../../../../repos/src/engine -I../../../../repos/src/core-utils -I../../../../repos/lib/libc -I../../../../repos/src/libqof/qof -mms-bitfields -Ic:/soft/gnome/include/glib-2.0 -Ic:/soft/gnome/lib/glib-2.0/include -DORBIT2=1 -mms-bitfields -Ic:/soft/gnome/include/gconf/2 -Ic:/soft/gnome/include/orbit-2.0 -Ic:/soft/gnome/include/glib-2.0 -Ic:/soft/gnome/lib/glib-2.0/include -Werror -Wdeclaration-after-statement -g -mms-bitfields -g -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations -Wno-unused -MT gnc-backend-dbi.lo -MD -MP -MF .deps/gnc-backend-dbi.Tpo -c ../../../../repos/src/backend/dbi/gnc-backend-dbi.c  -DDLL_EXPORT -DPIC -o .libs/gnc-backend-dbi.o
> ../../../../repos/src/backend/dbi/gnc-backend-dbi.c: In function `gnc_dbi_lock_database':
> ../../../../repos/src/backend/dbi/gnc-backend-dbi.c:482: warning: `dbi_conn_error_flag' is deprecated (declared at c:/soft/libdbi/include/dbi/dbi.h:203)
> ../../../../repos/src/backend/dbi/gnc-backend-dbi.c: In function `gnc_dbi_unlock':
> ../../../../repos/src/backend/dbi/gnc-backend-dbi.c:591: warning: `dbi_conn_error_flag' is deprecated (declared at c:/soft/libdbi/include/dbi/dbi.h:203)
> make[5]: *** [gnc-backend-dbi.lo] Error 1
> make[5]: Leaving directory `/c/soft/gnucash/build/src/backend/dbi'

Well, that was rude of them, especially since they haven't updated their online docs to reflect it. (The PDF in the source directory does.)

It's fixed, along with couple of other minor things, in r19740.

Thanks for the heads-up.

Regards,
John Ralls