[Bug 632166] sql backend silently fails and loses data

John Ralls jralls at ceridwen.us
Mon Oct 18 14:19:09 EDT 2010

On Oct 18, 2010, at 10:30 AM, Donald Allen wrote:

> John --
> This is reminiscent of a bug, 609583, that I reported and you and I worked on earlier this year. I just wanted to remind you of it in case the issues are the same (I haven't read the two bug reports carefully) and, if so, there might be something of use to you in the older report..
> /Don
> On Sun, Oct 17, 2010 at 10:54 PM, John Ralls <jralls at ceridwen.us> wrote:
>> I've been working on https://bugzilla.gnome.org/show_bug.cgi?id=632166 this afternoon. I can reproduce the bug, and I've added (but not yet checked in) a log message with more detail than the g_return_val_if_fail message. There should probably be one for each failure reason.
>> But to really address this, we need to pop up a message dialog telling the user that the save as didn't go well and that she can't rely on the saved database. The problem is that that's at least one new string to translate. The choices are to break the string freeze (my preference, because I don't think that we should release 2.4.0 with the possibility of screwing up the user's accounts) or take this off the milestone list for 2.4.


Good catch. It is the same problem exactly. 
When you closed the bug, you said that 2.2.9's Check and Repair fixed the missing currency field, which is interesting because 2.3.15's doesn't -- so that's a regression that needs to be fixed on top of everything else.

On the other hand, I'm leaning towards making the sql backend just note the missing currency in the log. That seems to be what the xml backend does. Even better, I suppose, would be to simply fix the missing field.

John Ralls

More information about the gnucash-devel mailing list