Bug 632594 created; review, approval, commit requested
tbullock at nd.edu
Wed Oct 20 07:54:39 EDT 2010
I reviewed your links and have these questions.
1. Are you saying do not modify gnucash-guide.xml at this time? If so, is that because Cristian is working on this module? If I don't modify it, then I just drop it from what my 'svn diff' found? I thought I had to correct all of 'xmllint' and 'svn diff''s findings? Cristian Marchi told me to fix them when I found them. See his email dated 10/19/2010, listed as the #3 in the digest vol 91, Issue 26. I don't know what you mean by mean fixing line breaks.
2. Regarding removing payroll chapter 14 by accident, please explain why that is? Before committing the patch I transformed the xml files to html and examined chapter 1 for the overview. It showed me chapters 11 thru 16 without any chapters missing. I looked at your changesets 19684 and 19686 and both seem to me to be saying that I am not deleting chapter 14, but am inserting 15 and 16 after it. In what way am I reading that incorrectly?
Thanks for your help.
> -----Original Message-----
> From: Yawar Amin [mailto:yawar.amin at gmail.com]
> Sent: Tuesday, October 19, 2010 11:06 PM
> To: Thomas Bullock
> Cc: gnucash-devel gnucash
> Subject: Re: Bug 632594 created; review, approval, commit requested
> Hi Tom,
> On 2010-10-19, at 15:52, Thomas Bullock wrote:
> > Developers,
> > This bug carries only very small tweaks to 3 files. Please advise
> me of any problems; otherwise, I request approval and install to
> Thanks for the patch! The grammar fix and overview chapter additions
> look good, committed.* The other changes look like simple line breaks,
> can we keep that for a future effort? That way, we can re-wrap and
> commit whole files at a time instead of a few lines here and there.
> Trunk commits are at  and , and 2.2 commits are at  and .
> I've also updated the Bugzilla page to reflect this.
> Best Regards,
> * It looked like your original patch inadvertently removed the Payroll
> chapter from the listing, so I kept the Payroll chapter and added the
> Budgets and Other Assets chapters as you intended.
>  http://svn.gnucash.org/trac/changeset/19685
>  http://svn.gnucash.org/trac/changeset/19686
>  http://svn.gnucash.org/trac/changeset/19683
>  http://svn.gnucash.org/trac/changeset/19684
>  https://bugzilla.gnome.org/show_bug.cgi?id=632594
More information about the gnucash-devel