r21125 - gnucash/trunk/src/libqof/qof - Fix weird include

Christian Stimming christian at cstimming.de
Mon Aug 8 15:21:43 EDT 2011


Am Montag, 8. August 2011 schrieb Geert Janssens:
> > I can answer the question why the qofmath128.c file was included directly
> > in gnc-numeric.c: The hope of the author at the time was that the
> > compiler will inline a bunch of those functions. They are used most
> > extensively in this gnc- numeric.c file and almost nowhere else. Hence,
> > the author thought it were a good idea to include the C code there so
> > that the compiler will inline as much of the calculation functions as
> > possible.
> > 
> > I think this does make some sense.
> > 
> > Regards,
> > 
> > Christian
> 
> Thanks for clarifying this. I have added your comment in the source file
> itself to prevent future questions about this.

Thanks for adding the comment to the source code. In fact I had intended to do 
that myself and already added some comment, but my local git repo seems to 
have forgotten about this change to the revert-commit and I dcommitted only 
the plain revert... Thanks for thinking of this.

Regards,

Christian


More information about the gnucash-devel mailing list