AUDIT: r21694 - gnucash/trunk/src/report/standard-reports - Fix table number alignment.

[Mike Evans]

On Fri, 09 Dec 2011 16:26:49 +0100
Geert Janssens <janssens-geert at telenet.be> wrote:

> Op vrijdag 9 december 2011 15:13:21 schreef Mike Evans:
> > On Fri, 09 Dec 2011 09:56:20 -0500
> > 
> > Derek Atkins <warlord at mit.edu> wrote:
> > > Mike,
> > > 
> > > Mike Evans <mikee at code.gnucash.org> writes:
> > > > Author: mikee
> > > > Date: 2011-12-09 07:31:39 -0500 (Fri, 09 Dec 2011)
> > > > New Revision: 21694
> > > > Trac: http://svn.gnucash.org/trac/changeset/21694
> > > > 
> > > > Modified:
> > > >    gnucash/trunk/src/report/standard-reports/net-barchart.scm
> > > > 
> > > > Log:
> > > > Fix table number alignment.
> > > > BP
> > > 
> > > This patch was a combination of white-space changes and your
> > > table-number alignment change.  It was very hard to follow the
> > > patch to figure out what the actual change was due to all the
> > > whitespace changes.   I *THINK* it looks like a single-line
> > > change, but I'm not sure.
> > > 
> > > In the future can you try to keep white-space changes separate
> > > from syntax changes?
> > > 
> > > -derek
> > 
> > Indeed it is single line change.
> > Curious though, as I didn't deliberately make any white space
> > changes. I'll check my editor settings...
> > 
> > Ah! I see I've set it to strip trailing spaces which may have the
> > problem.  Will try to avoid in future.  Thanks.
> > 
> I actually like the fact that trailing whitespace is stripped. The
> whitespace changes should just be committed separately.
> 
> Geert

I'd forgotten I'd set the editor (geany) to that though so it was a
complete accident.

OK to backport to 2.4?

Mike

> 
> > Mike Evans
> > 
> > 
> > 
> > _______________________________________________
> > gnucash-devel mailing list
> > gnucash-devel at gnucash.org
> > https://lists.gnucash.org/mailman/listinfo/gnucash-devel