r21736 - gnucash/trunk/src - Fix circular dependency between test-core and qof-test.

[Geert Janssens]

On 18-12-11 22:53, John Ralls wrote:
> On Dec 18, 2011, at 11:47 AM, Geert Janssens wrote:
>
>> On 17-12-11 20:32, John Ralls wrote:
>>> Author: jralls
>>> Date: 2011-12-17 14:32:27 -0500 (Sat, 17 Dec 2011)
>>> New Revision: 21736
>>> Trac: http://svn.gnucash.org/trac/changeset/21736
>>>
>>> Modified:
>>>     gnucash/trunk/src/Makefile.am
>>>     gnucash/trunk/src/libqof/qof/test/Makefile.am
>>> Log:
>>> Fix circular dependency between test-core and qof-test.
>>>
>>>
>>> Compile test-core/test-stuff.c into test-qof, then recompile test-core as a module for dealing with noise from Guile and Python tests.
>> Hmm, while this may work, it strikes me as quite an ugly hack. Is there really no way to do this and avoid bidirectional dependencies between libqof and test-core ?
> Yes: Get rid of QOFEvents and use GObject Signals, which I intend as part of GObjectification.
>
> The other, slightly less ugly, fix would be to move the log-silencing code into qof and export it, but then it becomes part of the API instead of being a test function. I didn't like that idea much, so I resorted to the hack.
>
> Regards,
> John Ralls
>
Ok, thanks for the clarification. With that I agree your hack is the 
best short-term fix.

Perhaps we should add a comment though to remind us this is a hack and 
should be fixed during the GObjectification ?

Geert