r21579 - gnucash/trunk - [Cruft Reduction] Remove unused functions from src/engine

[Geert Janssens]

John,

Since you have removed these unused functions, the python bindings spew some 
errors during GnuCash startup (if built with python bindings enabled of 
course). Here's one example:

Traceback (most recent call last):
  File "/kobaltnet/janssege/Development/Installs/gnucash-f15-
trunk/share/gnucash/python/init.py", line 3, in <module>
    from gnucash import *
  File "/home/janssege/Development/Installs/gnucash-f15-
trunk/lib/python2.7/site-packages/gnucash/__init__.py", line 6, in <module>
    from gnucash_core import *
  File "/home/janssege/Development/Installs/gnucash-f15-
trunk/lib/python2.7/site-packages/gnucash/gnucash_core.py", line 636, in 
<module>
    methods_return_instance(Account, account_dict)
  File "/home/janssege/Development/Installs/gnucash-f15-
trunk/lib/python2.7/site-packages/gnucash/function_class.py", line 223, in 
methods_return_instance
    method_function_returns_instance( getattr(cls, func_name), instance_name))
AttributeError: type object 'Account' has no attribute 'get_start_balance'

The python bindings explicitly wrap a number of the functions you removed. 
This doesn't mean they are actually used though.

I have tried to remove the corresponding wrapper code for a few functions from 
src/optional/python-bindings/gnucash_core.py. This does each time solve the 
error displayed, but reports a new error for the next deleted function.

Since you only commented out the functions right now in the engine, I'm not 
sure what should happen with the wrappers in python: should they also simply 
get commented out or rather removed ?

Geert

On vrijdag 18 november 2011, John Ralls wrote:
> Author: jralls
> Date: 2011-11-18 16:04:01 -0500 (Fri, 18 Nov 2011)
> New Revision: 21579
> Trac: http://svn.gnucash.org/trac/changeset/21579
> 
> Removed:
>    gnucash/trunk/src/engine/gnc-session-scm.c
>    gnucash/trunk/src/engine/gnc-session-scm.h
> Modified:
>    gnucash/trunk/po/POTFILES.in
>    gnucash/trunk/src/core-utils/gnc-main.c
>    gnucash/trunk/src/engine/Account.c
>    gnucash/trunk/src/engine/Account.h
>    gnucash/trunk/src/engine/CMakeLists.txt
>    gnucash/trunk/src/engine/Makefile.am
>    gnucash/trunk/src/engine/SX-ttinfo.h
>    gnucash/trunk/src/engine/SchedXaction.c
>    gnucash/trunk/src/engine/SchedXaction.h
>    gnucash/trunk/src/engine/Scrub2.c
>    gnucash/trunk/src/engine/Scrub2.h
>    gnucash/trunk/src/engine/Split.c
>    gnucash/trunk/src/engine/Split.h
>    gnucash/trunk/src/engine/TransLog.c
>    gnucash/trunk/src/engine/Transaction.c
>    gnucash/trunk/src/engine/Transaction.h
>    gnucash/trunk/src/engine/engine-helpers.c
>    gnucash/trunk/src/engine/engine-helpers.h
>    gnucash/trunk/src/engine/engine.i
>    gnucash/trunk/src/engine/gnc-associate-account.c
>    gnucash/trunk/src/engine/gnc-associate-account.h
>    gnucash/trunk/src/engine/gnc-budget.c
>    gnucash/trunk/src/engine/gnc-budget.h
>    gnucash/trunk/src/engine/gnc-commodity.c
>    gnucash/trunk/src/engine/gnc-commodity.h
>    gnucash/trunk/src/engine/gnc-engine.c
>    gnucash/trunk/src/engine/gnc-engine.h
>    gnucash/trunk/src/engine/gnc-hooks.c
>    gnucash/trunk/src/engine/gnc-hooks.h
>    gnucash/trunk/src/engine/gnc-lot.c
>    gnucash/trunk/src/engine/gnc-lot.h
>    gnucash/trunk/src/engine/gnc-pricedb.c
>    gnucash/trunk/src/engine/gnc-pricedb.h
>    gnucash/trunk/src/engine/gncBillTerm.c
>    gnucash/trunk/src/engine/gncBillTerm.h
>    gnucash/trunk/src/engine/gncBusGuile.c
>    gnucash/trunk/src/engine/gncBusGuile.h
>    gnucash/trunk/src/engine/gncCustomer.h
>    gnucash/trunk/src/engine/gncEmployee.c
>    gnucash/trunk/src/engine/gncEmployee.h
>    gnucash/trunk/src/engine/gncEntry.c
>    gnucash/trunk/src/engine/gncEntry.h
>    gnucash/trunk/src/engine/gncInvoice.c
>    gnucash/trunk/src/engine/gncInvoice.h
>    gnucash/trunk/src/engine/gncJob.c
>    gnucash/trunk/src/engine/gncOrder.c
>    gnucash/trunk/src/engine/gncOrder.h
>    gnucash/trunk/src/engine/gncOwner.c
>    gnucash/trunk/src/engine/gncOwner.h
>    gnucash/trunk/src/engine/gncTaxTable.c
>    gnucash/trunk/src/engine/gncVendor.c
>    gnucash/trunk/src/engine/gncVendor.h
>    gnucash/trunk/src/engine/kvp-scm.c
>    gnucash/trunk/src/engine/kvp-scm.h
>    gnucash/trunk/src/engine/policy.c
>    gnucash/trunk/src/engine/policy.h
>    gnucash/trunk/src/engine/test/utest-Account.c
> Log:
> [Cruft Reduction] Remove unused functions from src/engine
> 
> 
> Nothing in gnc-session-scm.c was being used, so deleted it and its
> corresponding header.
> 
> _______________________________________________
> gnucash-patches mailing list
> gnucash-patches at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches