r21508 - gnucash/trunk/src/gnome - Protect strcmp from crashing on NULL values

John Ralls jralls at ceridwen.us
Mon Oct 31 12:22:19 EDT 2011


On Oct 31, 2011, at 8:07 AM, Geert Janssens wrote:

> OAnd by the way, I don't see much use for safe_strcmp anymore in gnucash. I'd 
> rather user g_strcmp0, which behaves exactly the same, but is part of glibc. 
> Our code is heavily dependent on glibc anyway, so I prefer to use its 
> convenience functions over maintaining our own.


Yes, please. Let's prefer GLib utilities. No need to make a special effort, just whenever you notice something that can be replaced with a GLib function or macro, change it out.

Regards,
John Ralls




More information about the gnucash-devel mailing list