Tag builds from git

[Geert Janssens]

Derek,

Thanks, that's probably it. I remember having problems with the newlines 
in trunk as well.

I believe this problem is due to the switch from svn to git: in svn we 
have set the property
svn:eol-style LF
on all source files. This ensures the files have LF line endings.

An equivalent exists for git, but I don't think it has been set in our 
repositories. As such configure.ac is checked out with CRLF line 
endings. And due to this empty lines are no longer ignored by 
AC_CONFIG_FILES (it still contains a CR).

So the solution can be either one of
- figuring out how to use the git equivalent of svn:eol-style LF. git 
help config has some basic information on safecrlf and autocrlf, but it 
mostly refers to man gitattributes for more information. I haven't had 
time to look deeper.
- remove the empty lines. This can be a quick workaround to get 2.4.11 
and future tags to build. But we should really investigate a proper line 
ending configuration. Without it trying to check in a one line change 
from a Windows PC will result in the complete file seen as modified due 
to changing line endings.

In any case, I think the tag builds from git will have to wait until 
this is fixed.

Geert

On 16-08-12 19:23, Derek Atkins wrote:
> Geert,
>
> try removing the blank lines in AC_CONFIG_FILES().  In particular, I think
> this is the issue:
>
>    src/business/business-ledger/Makefile
>
>    dnl # Stuff for bill/invoice import plugin
>    src/plugins/Makefile
>    src/plugins/bi_import/Makefile
>    src/plugins/bi_import/glade/Makefile
>    src/plugins/bi_import/ui/Makefile
>    dnl # non-makefiles
>    dnl # Please read doc/build-system before adding *anything* here
>
>    ,
>
> If you remove those blank lines then I think it'll work.
>
> I have no idea how the 2.4.11 build worked in the first place, but maybe
> something else has changed because of git v. svn.
>
> I'll also note that trunk has those lines removed.
>
> -derek
>
> On Thu, August 16, 2012 1:15 pm, Geert Janssens wrote:
>> I have been stabbing at the tag build script today to get it working in
>> a git context. There were some silly typos to fix, I had to restart a
>> build because of a network glitch at the wrong time,... This is a slow
>> and frustrating process, because the tag builds typically run for hours.
>>
>> Anyway. The last tag build failed while configuring gnucash. I don't
>> think this has anything to do with my git modifications though, so I'd
>> like some input on what could be the problem. The log of the last build
>> can be found here:
>> http://code.gnucash.org/builds/win32/build-logs/build-2.4.11-2012-08-16.log
>>
>> The last part is this:
>> ############################################################
>> ###  GnuCash
>> ############################################################
>> Creating po/POTFILES.in ...
>> Creating aclocal.m4 ...
>> Running glib-gettextize --force --copy ...
>> GnuCash note: Please ignore the output of glib-gettextize below!
>> Copying file mkinstalldirs
>> Copying file po/Makefile.in.in
>>
>> Please add the files
>>     codeset.m4 gettext.m4 glibc21.m4 iconv.m4 isc-posix.m4 lcmessage.m4
>>     progtest.m4
>> from the /aclocal directory to your autoconf macro directory
>> or directly to your aclocal.m4 file.
>> You will also need config.guess and config.sub, which you can get from
>> ftp://ftp.gnu.org/pub/gnu/config/.
>>
>> GnuCash note: Please ignore the output of glib-gettextize above!
>>
>> Ensure aclocal.m4 is writable ...
>> Ensure po/POTFILES.in is writable ...
>> Running intltoolize --force --copy ...
>> You should add the contents of
>> '/c/soft/gnucash-2.4.11/gnome/share/aclocal/intltool.m4' to 'aclocal.m4'.
>> Running libtoolize --force --copy ...
>> libtoolize: putting auxiliary files in `.'.
>> libtoolize: copying file `./ltmain.sh'
>> libtoolize: putting macros in `macros'.
>> libtoolize: copying file `macros/libtool.m4'
>> libtoolize: copying file `macros/ltoptions.m4'
>> libtoolize: copying file `macros/ltsugar.m4'
>> libtoolize: copying file `macros/ltversion.m4'
>> libtoolize: copying file `macros/lt~obsolete.m4'
>> libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac
>> and
>> libtoolize: rerunning libtoolize, to keep the correct libtool macros
>> in-tree.
>> Running aclocal -I /c/soft/gnucash-2.4.11/aqbanking/share/aclocal -I
>> /c/soft/gnucash-2.4.11/gwenhywfar/share/aclocal -I
>> /c/soft/gnucash-2.4.11/gnutls/share/aclocal -I
>> /c/soft/gnucash-2.4.11/guile/share/aclocal -I
>> /c/soft/gnucash-2.4.11/gnome/share/aclocal -I
>> /c/soft/gnucash-2.4.11/autotools/share/aclocal -I macros ...
>> configure.ac:1445: error: `
>> ' is already registered with AC_CONFIG_FILES.
>> ../../lib/autoconf/status.m4:305: AC_CONFIG_FILES is expanded from...
>> configure.ac:1445: the top level
>> autom4te: /bin/m4 failed with exit status: 1
>> aclocal: autom4te failed with exit status: 1
>> **Error**: aclocal failed.
>>
>> I'm not good at autotools, so perhaps someone can interpret this for me ?
>>
>> This build started from a cloned git repository in which tag 2.4.11 was
>> checked out (which for git is equivalent to svn rev 22265 on the 2.4
>> branch).
>>
>> Geert
>> _______________________________________________
>> gnucash-devel mailing list
>> gnucash-devel at gnucash.org
>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>>
>