r22325 - gnucash/trunk/packaging/win32 - Win32 nightly build: add timestamp in package name created from git

[Geert Janssens]

On 17-08-12 15:57, Derek Atkins wrote:
> Geert Janssens <gjanssens at code.gnucash.org> writes:
>
>> +++ gnucash/trunk/packaging/win32/build_package_git.sh	2012-08-16 16:21:08 UTC (rev 22325)
>> @@ -74,7 +74,7 @@
>>   # Choose the output filename based on our "build_from_tarball" setting
>>   # Make sure this logic matches the logic in dist.sh!
>>   if [ "$BUILD_FROM_TARBALL" = "no" ]; then
>> -  SETUP_FILENAME="gnucash-${PKG_VERSION}-git-r${SVN_REV}-setup.exe"
>> +  SETUP_FILENAME="gnucash-${PKG_VERSION}-$(date +'%Y-%m-%d')-git-${SVN_REV}-setup.exe"
> Any particular reason to continue using SVN_REV in build_package_git?   ;)
>
> -derek
>
Well, that's just the name of the variable.

You can't see this in the commit diff, but a few lines earlier this 
parameter is set by extracting the SVN_REV definition from 
gnc-svninfo.h. That file in turn is generated during at compile time by 
a small shell script.

Depending on the revision system used, this script will parse the git, 
svn or even bzr revision number/hash. But it will continue to call the 
parameter SVN_REV. That was probably done to avoid breakage in 
unexpected places (like the Windows build system). It may be time to 
revise this, now we're in the process of moving to git.

Geert