Build error: Re: r22628 - gnucash/trunk/src - Convert all time_t to time64: optional & plugins
John Ralls
jralls at ceridwen.us
Mon Dec 3 07:50:26 EST 2012
On Dec 2, 2012, at 5:11 PM, Derek Atkins <derek at ihtfp.com> wrote:
>
> On Sun, December 2, 2012 7:56 pm, Alex Aycinena wrote:
> [snip]
>>>> /home/gnucash-dev/svncheckouts/gnucash-clean/src/gnome/assistant-acct-period.c:
>>>> In function 'ap_assistant_menu_prepare':
>>>> /home/gnucash-dev/svncheckouts/gnucash-clean/src/gnome/assistant-acct-period.c:309:5:
>>>> error: format '%lld' expects argument of type 'long long int', but
>>>> argument 5 has type 'time64' [-Werror=format]
>>>> /home/gnucash-dev/svncheckouts/gnucash-clean/src/gnome/assistant-acct-period.c:
>>>> In function 'ap_assistant_create':
>>>> /home/gnucash-dev/svncheckouts/gnucash-clean/src/gnome/assistant-acct-period.c:574:5:
>>>> error: format '%lld' expects argument of type 'long long int', but
>>>> argument 5 has type 'time64' [-Werror=format]
>>>> cc1: all warnings being treated as errors
>>>> make[4]: *** [assistant-acct-period.lo] Error 1
>>>
>>>
>>> Alex,
>>>
>>> That's interesting. Is this a 64-bit build, and does your compiler
>>> expect a long-long to be 128-bit?
>>>
>>> Regards,
>>> John Ralls
>>
>> John,
>>
>> Yes, Fedora 15, 64-bit. I don't have a clue what my compiler expects a
>> long-long to be (e.g., 128-bit). Basically, I update, run
>> ./autogen.sh, switch to my build directory, run configure with all the
>> switches, then make.
>
> Yes, on Linux/64 a long long is 128 bits.
>
> John, you should probably just use the G_INT64_FORMAT macro (or the
> unsigned equivalent, depending on your type). This will do the right
> thing and be %ld on 64-bit platforms, but %lld on 32-bit platforms. You
> can see how it's used in order places in the code for examples.
>
Ah, that works. Thanks.
>> Would you like any further info from me?
>
> I would guess he might need more testing. ;)
No, I was able to reproduce it on a 64-bit Debian VM. r22630 fixes it.
Regards,
John Ralls
More information about the gnucash-devel
mailing list