Error when running test suite

Derek Atkins warlord at MIT.EDU
Mon Dec 2 10:06:14 EST 2013


John Ralls <jralls at ceridwen.us> writes:

> On Nov 27, 2013, at 1:41 PM, Geert Janssens <janssens-geert at telenet.be> wrote:
>
>> On Wednesday 27 November 2013 11:31:24 John Ralls wrote:
>> > The comment ahead of that test function says:
>> > /*
>> >  * There are some differences between distros in the way they name
>> >  * locales, and this can cause trouble with the locale-based
>> >  * formatting. If you get the assert in this function, run locale -a
>> >  * and make sure that en_US, en_GB, and fr_FR are installed and that
>> >  * if a suffix is needed it's in the suffixes array.
>> >  */
>> > 
>> > The reason is that the test exercises the date functions in those
>> > locales to ensure that the i18n part of the date routines is
>> > functioning correctly.
>> > 
>> > Regards,
>> > John Ralls
>> > 
>> John,
>>  
>> would it make sense for the test to write a similar message to the
>> log in case this assert is reached ? Not everybody looks in the test
>> source automatically.
>> 
>
> Geert,
>
> Well, print out to stderr. There is no log. 
>
> OK. This is the third time this has come up on the list. In this
> particular case, it’s an easy change. r23451.

Arguably the test shouldn't CRASH if the locales don't exist; it should
at least fail gracefully, no?

> Regards,
> John Ralls

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available



More information about the gnucash-devel mailing list