Error when running test suite

[Derek Atkins]

John Ralls <jralls at ceridwen.us> writes:

>> There's a difference between a test failing and the environment being
>> incorrect (e.g. due to a missing locale).  In this case it's a broken
>> environment -- it's something easily correctable by someone running the
>> tests so IMHO the failure should not be fatal and instead should tell
>> the user about their broken environment.  It's not an issue that
>> requires a developer to look at it (in which case a crash is arguably
>> better, although personally I'd rather the crash be forced only while
>> debugging the test rather than while running a put "make check").
>
> Fair enough, though anything short of a hard failure is unlikely to be
> noticed in the spew of output from 'make check'. OTOH, most folks
> don't care whether GC works in all locales, only that it works in
> their locale. It would be a simple enough change to try setlocale for
> each test locale and then test only the ones that work, while emitting
> a warning that the others aren't being tested, similar to what we do
> with dbi backends.

Also arguably we should upmark failures as part of "make check".  At the
end of "make check" it should print out a big PASS or FAIL (possibly
with the # of test failures), and maybe even exit with a non-zero exit
code.  I'm just not sure how to do that.  (I thought it *used* to do
that)

> Regards,
> John Ralls

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available