[PATCH] Add back translation support in combo boxes

[Geert Janssens]

Hi Aurimas,

Thanks for the patch.

I have looked at it but didn't apply it yet. My knowledge of gettext is 
limited, but it looks odd to me to wrap a variable inside the _() macro. 
I noticed this was the same in the old code you refer to, but I don't 
know if this is correct or not. Perhaps someone with a better 
understanding of gettext can give his opinion ?

Geert

On 30-06-13 17:24, Aurimas Fis(eras wrote:
> It was accidentally removed in 1286a896a66a3002e98913b9016f1dc56f7137d7
>
> 0004-Add-back-translation-support-in-combo-boxes.patch
>
>
>  From aa9b44eb752535231a8e2812ff9d078eaf4ac3ff Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Aurimas=20Fi=C5=A1eras?=<aurimas at members.fsf.org>
> Date: Sun, 30 Jun 2013 18:19:07 +0300
> Subject: Add back translation support in combo boxes
>
> that was accidentally removed in 1286a896a66a3002e98913b9016f1dc56f7137d7
> ---
>   src/gnome-utils/dialog-options.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/gnome-utils/dialog-options.c b/src/gnome-utils/dialog-options.c
> index f3f6c1b..35883ad 100644
> --- a/src/gnome-utils/dialog-options.c
> +++ b/src/gnome-utils/dialog-options.c
> @@ -608,7 +608,9 @@ gnc_option_create_multichoice_widget(GNCOption *option)
>               itemstring = gnc_option_permissible_value_name(option, i);
>               description = gnc_option_permissible_value_description(option, i);
>               gtk_list_store_append (store, &iter);
> -            gtk_list_store_set (store, &iter, 0, itemstring, 1, description, -1);
> +            gtk_list_store_set (store, &iter, 0,
> +                                (itemstring && *itemstring) ? _(itemstring) : "", 1,
> +                                (description && *description) ?_(description) : "", -1);
>               if (itemstring)
>                   g_free(itemstring);
>               if (description)
> -- 1.8.3.1
>
>
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel