no git patchset from .news files? (was Re: gnucash-htdocs branch master updated. svn_last-12-g3580119)
John Ralls
jralls at ceridwen.us
Mon Jul 15 19:17:47 EDT 2013
On Jul 15, 2013, at 2:07 PM, Derek Atkins <warlord at mit.edu> wrote:
> John Ralls <jralls at ceridwen.us> writes:
>
>>> Good question. I haven't looked at that yet, but I think so.
>>
>> Confirmed: It doesn't matter. A single commit, even a git tag -a or a
>> git merge, has a subject line. Here's what I've written:
>> Single commit:
>>
>> Subject: gnucash trunk: Update Danish TRanslation, copied from the
>> Translation Project.
>>
>> Multiple commits:
>> Subject: Multiple changes pushed to gnucash master
>
> Any chance we could standardize on one way to output the subject, e.g.:
>
> Subject: <project> <branch>: <Message>
>
> So that would result in:
>
> Subject: gnucash trunk: Update Danish TRanslation, copied from the
> Translation Project.
>
> or
>
> Subject: gnucash master: Multiple changes pushed
>
> [snip]
Sure.
>
>> The other thing that I notice is that the summary of changes is for
>> the whole push. That's fine if all of the commits are about more or
>> less the same thing, but it might be puzzling if they're a bunch of
>> unrelated bug-fixes. I'm inclined to say that we should remove the
>> summary at the end of the message and incorporate it into the
>> per-change log instead by changing custom_showrev to either "git log
>> -n 1 --stat %s" or "git log -n 1 --patch-with-stat %s" depending upon
>> which list it's going to.
>
> I'm not sure I know enough yet to give an informed answer. Could you
> show some example output for what each would look like? (I guess I
> could run the commands myself to look).
This is what the current scheme looks like:
commit 8881c1a10061d60c83f8535c1094718687e2c604
Author: jralls <jralls at 57a11ea4-9604-0410-9ed3-97b8803252fd>
Date: Tue Feb 12 23:09:54 2013 +0000
Fix gnc-cdate format to match that of POSIX cdate
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22776 57a11ea4-9604-0410-9ed3-97b8803252fd
commit 6b0ade185139b0b88ee84351cd248ce8a3ea8ee5
Author: Christian Stimming <stimming at tuhh.de>
Date: Fri Feb 8 20:47:42 2013 +0000
Get cutecash/C++ to compile again.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22767 57a11ea4-9604-0410-9ed3-97b8803252fd
commit 679d59e4451b62c1115c51942b4a99feb69f24e7
Author: Mike Evans <mikee at saxicola.co.uk>
Date: Fri Feb 8 11:02:55 2013 +0000
Bug 683881 Partial implementation.
TODO:
Saving search preferences doesn't save reverse sort.
The blank_split remains at the bottom of the register when reverse
sorted.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22766 57a11ea4-9604-0410-9ed3-97b8803252fd
commit 9ba6e69d5e22c29cfb2066c1360ee549e72e4501
Author: Mike Alexander <mta at umich.edu>
Date: Wed Feb 6 04:24:38 2013 +0000
Avoid a crash when entering invalid dates (e.g., enter "111" for a transaction date).
gnc_parse_date is ignoring the return code from qof_scan_date which causes it to
send uninitialized values to gnc_mktime which crashes if the date is too ridiculous.
Presumably this worked before because mktime took anything without crashing.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22755 57a11ea4-9604-0410-9ed3-97b8803252fd
Summary of changes:
src/CMakeLists.txt | 2 +
src/core-utils/CMakeLists.txt | 14 ++++++-
src/engine/CMakeLists.txt | 7 ----
src/gnc/CMakeLists.txt | 1 +
src/gnc/main.cpp | 1 +
src/gnome/gnc-plugin-page-register.c | 43 ++++++++++++++++++++++
src/gnome/gnc-split-reg.c | 11 ++++++
src/gnome/gnc-split-reg.h | 6 +++
.../gtkbuilder/gnc-plugin-page-register.glade | 38 +++++++++++++------
src/libqof/CMakeLists.txt | 2 +
src/libqof/qof/gnc-date.c | 2 +-
src/libqof/qof/test/test-gnc-date.c | 2 +-
src/register/register-gnome/datecell-gnome.c | 10 ++++-
13 files changed, 116 insertions(+), 23 deletions(-)
And this is what it looks like with git log --stat:
commit 8881c1a10061d60c83f8535c1094718687e2c604
Author: jralls <jralls at 57a11ea4-9604-0410-9ed3-97b8803252fd>
Date: Tue Feb 12 23:09:54 2013 +0000
Fix gnc-cdate format to match that of POSIX cdate
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22776 57a11ea4-9604
src/libqof/qof/gnc-date.c | 2 +-
src/libqof/qof/test/test-gnc-date.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
commit 6b0ade185139b0b88ee84351cd248ce8a3ea8ee5
Author: Christian Stimming <stimming at tuhh.de>
Date: Fri Feb 8 20:47:42 2013 +0000
Get cutecash/C++ to compile again.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22767 57a11ea4-9604
src/CMakeLists.txt | 2 ++
src/core-utils/CMakeLists.txt | 14 +++++++++++++-
src/engine/CMakeLists.txt | 7 -------
src/gnc/CMakeLists.txt | 1 +
src/gnc/main.cpp | 1 +
src/libqof/CMakeLists.txt | 2 ++
6 files changed, 19 insertions(+), 8 deletions(-)
commit 679d59e4451b62c1115c51942b4a99feb69f24e7
Author: Mike Evans <mikee at saxicola.co.uk>
Date: Fri Feb 8 11:02:55 2013 +0000
Bug 683881 Partial implementation.
TODO:
Saving search preferences doesn't save reverse sort.
The blank_split remains at the bottom of the register when reverse
sorted.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22766 57a11ea4-9604
src/gnome/gnc-plugin-page-register.c | 43 ++++++++++++++++++++++
src/gnome/gnc-split-reg.c | 11 ++++++
src/gnome/gnc-split-reg.h | 6 +++
.../gtkbuilder/gnc-plugin-page-register.glade | 38 +++++++++++++------
4 files changed, 86 insertions(+), 12 deletions(-)
commit 9ba6e69d5e22c29cfb2066c1360ee549e72e4501
Author: Mike Alexander <mta at umich.edu>
Date: Wed Feb 6 04:24:38 2013 +0000
Avoid a crash when entering invalid dates (e.g., enter "111" for a transacti
gnc_parse_date is ignoring the return code from qof_scan_date which causes i
send uninitialized values to gnc_mktime which crashes if the date is too rid
Presumably this worked before because mktime took anything without crashing.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22755 57a11ea4-9604
src/register/register-gnome/datecell-gnome.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
Here's the first changeset with --patch-with-stat:
commit 8881c1a10061d60c83f8535c1094718687e2c604
Author: jralls <jralls at 57a11ea4-9604-0410-9ed3-97b8803252fd>
Date: Tue Feb 12 23:09:54 2013 +0000
Fix gnc-cdate format to match that of POSIX cdate
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22776 57a11ea4-9604
---
src/libqof/qof/gnc-date.c | 2 +-
src/libqof/qof/test/test-gnc-date.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libqof/qof/gnc-date.c b/src/libqof/qof/gnc-date.c
index 6a24add..ea2d837 100644
--- a/src/libqof/qof/gnc-date.c
+++ b/src/libqof/qof/gnc-date.c
@@ -432,7 +432,7 @@ gchar*
gnc_ctime (const time64 *secs)
{
GDateTime *gdt = gnc_g_date_time_new_from_unix_local (*secs);
- gchar *string = g_date_time_format (gdt, "%a %b %H:%M:%S %Y");
+ gchar *string = g_date_time_format (gdt, "%a %b %e %H:%M:%S %Y\n");
g_date_time_unref (gdt);
return string;
}
diff --git a/src/libqof/qof/test/test-gnc-date.c b/src/libqof/qof/test/test-gnc-
index f3bffcc..38f297f 100644
--- a/src/libqof/qof/test/test-gnc-date.c
+++ b/src/libqof/qof/test/test-gnc-date.c
@@ -290,7 +290,7 @@ test_gnc_ctime (void)
GDateTime *gdt = gncdt.new_from_unix_local (secs[ind]);
gchar* datestr = gnc_ctime (&secs[ind]);
g_assert_cmpstr (datestr, ==,
- g_date_time_format (gdt, "%a %b %H:%M:%S %Y"));
+ g_date_time_format (gdt, "%a %b %e %H:%M:%S %Y\n"));
g_date_time_unref (gdt);
g_free (datestr);
}
Regards,
John Ralls
More information about the gnucash-devel
mailing list