r23026 - gnucash/trunk/src/report/standard-reports/test - Add test suite for standard tests

[Geert Janssens]

Hi Peter,

Thank you for your patch.

I had already come up with another fix which I just pushed to the repository. I'm not 
sure which one is the cleanest though. Automake is not my best skill.

If someone thinks your way is better, I don't mind if it gets used instead of my fix.

Geert

On Monday 03 June 2013 21:44:46 Peter Broadbery wrote:
> Hi,
> 
> I've appended a patch that should fix the problem with patsubst, and
> updated my git repository with a slightly extended version of the same
> thing (the report-system/test makefile wasn't 100% either).  Tree:
> https://github.com/pbroadbery/gnucash/tree/pab/topic/report-test-fixu
> p
> 
> I probably ought to ask - what's the policy on gnumake functions?
> $(shell) is used quite extensively,
> 
> Peter
> 
> On Mon, Jun 3, 2013 at 8:04 PM, Derek Atkins <warlord at mit.edu> wrote:
> > Geert Janssens <gjanssens at code.gnucash.org> writes:
> >> --- gnucash/trunk/src/report/standard-reports/test/Makefile.am     
> >>   2013-06-02 10:32:18 UTC (rev 23025) +++
> >> gnucash/trunk/src/report/standard-reports/test/Makefile.am       
> >> 2013-06-02 10:32:39 UTC (rev 23026) +$(patsubst
> >> %.scm,%,$(SCM_TESTS)): %: Makefile .scm-links
> >> +     echo 'guile --debug -l $(srcdir)/$*.scm -c "(exit
> >> (run-test))"' > $@ +     chmod a+x $@
> >> +
> > 
> > I suspect this is the code that's causing the build issues.  We
> > shouldn't be using the $(patsubst ... in the Makefile.
> > 
> > -derek
> > 
> > --
> > 
> >        Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
> >        Member, MIT Student Information Processing Board  (SIPB)
> >        URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
> >        warlord at MIT.EDU                        PGP key available
> > 
> > _______________________________________________
> > gnucash-devel mailing list
> > gnucash-devel at gnucash.org
> > https://lists.gnucash.org/mailman/listinfo/gnucash-devel
> 
> ----------------- src/report/standard-reports/test/Makefile.am
> ----------------- index 0406519..35bb2e6 100644
> @@ -40,17 +40,16 @@ TESTS_ENVIRONMENT = \
>  EXTRA_DIST = test-load-module
> 
>  SCM_TESTS = \
> -	test-standard-category-report.scm \
> -	test-standard-net-barchart.scm \
> -	test-standard-net-linechart.scm
> +	test-standard-category-report \
> +	test-standard-net-barchart \
> +	test-standard-net-linechart
> 
>  if GNUCASH_SEPARATE_BUILDDIR
>  #For executing test cases
>  SCM_FILE_LINKS = \
>  	test-generic-category-report.scm \
>  	test-generic-net-barchart.scm \
> -	test-generic-net-linechart.scm \
> -	$(SCM_TESTS)
> +	test-generic-net-linechart.scm
>  endif
> 
>  .scm-links:
> @@ -67,7 +66,7 @@ if ! OS_WIN32
>  	touch .scm-links
>  endif
> 
> -$(patsubst %.scm,%,$(SCM_TESTS)): %: Makefile .scm-links
> +$(SCM_TESTS): %: $(srcdir)/%.scm Makefile .scm-links
>  	echo 'guile --debug -l $(srcdir)/$*.scm -c "(exit (run-test))"' > $@
> chmod a+x $@
> 
> @@ -75,9 +74,9 @@ interp:
>  	$(TESTS_ENVIRONMENT) guile --debug
> 
>  debug:
> -	$(TESTS_ENVIRONMENT) gdb --args $(shell cat $(TEST))
> +	$(TESTS_ENVIRONMENT) gdb --args $(shell cat ${TEST})
> 
> -TESTS = $(patsubst %.scm,%,$(SCM_TESTS)) $(MODULE_TESTS)
> +TESTS = $(SCM_TESTS) $(MODULE_TESTS)
> 
>  clean-local:
>  	$(RM) -rf gnucash
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel