Odd message from git post-receive hook

Geert Janssens janssens-geert at telenet.be
Tue Nov 26 15:06:27 EST 2013


On Tuesday 26 November 2013 11:59:05 John Ralls wrote:
> On Nov 26, 2013, at 9:08 AM, Geert Janssens <janssens-geert at telenet.be> wrote:
> > 
> > So how come the mail script whips up the wrong subject ?
> > 
> > Geert
> > 
> > 
> > ----------  Forwarded Message  ----------
> > 
> > Subject: gnucash 2.4: Report the proper minimum version for
> > libgoffice when not found at configure time
> > Date: Tuesday 26 November 2013, 11:57:04
> > From: GIT SVN Migration User <git-svn at code.gnucash.org>
> > To: info at kobaltwit.be
> > 
> > Updated	 via  https://github.com/Gnucash/gnucash/commit/907e9112
> > (commit)> 
> > 	from  https://github.com/Gnucash/gnucash/commit/7b7e57a6 (commit)
> 
> Because line 232 says:
> 	subject="$projectdesc $short_refname: $(git log -n 1 --format=%s
> $newref)” Which is the right answer only when git is checked out in
> the right branch.
> 
> We could make it
>   if [ “x$refname_type” = “xbranch” ]; then
> 	subject="$projectdesc $short_refname: $(git log -b $refname -n 1
> --format=%s $newref)” else
> 	subject="$projectdesc $short_refname: $(git log -n 1 --format=%s
> $newref)”
> 
>   fi
> 
> Which would fix most instances.
> 
> Regards,
> John Ralls
That's worth a try.

Geert


More information about the gnucash-devel mailing list