qof_commit_edit_part_2 commit, then delete

[Phil Longstaff]

Just check that the commit isn't what triggers a DELETE sql statement.


On Thu, Nov 28, 2013 at 5:05 AM, Christian Stimming
<christian at cstimming.de>wrote:

> Am Mittwoch, 27. November 2013, 16:45:03 schrieb John Ralls:
> > As it now stands, we run the commit code, then check priv->do_free and
> run
> > the destroy callback if it’s true.
> >
> > Wouldn’t it make more sense to *not* run the commit code if we’re
> destroying
> > the instance?
>
> Yes, this would make more sense.
>
> On another note, the whole semantics of begin_edit, commit_edit and so on
> seem
> still only half-implemented to me. If you or anyone else can come up with a
> better design here, preferably covered by unittests, I'm all for this as
> well.
>
> Regards,
>
> Christian
>
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>